Skip to content

[Upgrade Assistant] Update upgrade guide doc links#123953

Merged
alisonelizabeth merged 4 commits intoelastic:7.17from
alisonelizabeth:ua/cloud_upgrade_link
Jan 27, 2022
Merged

[Upgrade Assistant] Update upgrade guide doc links#123953
alisonelizabeth merged 4 commits intoelastic:7.17from
alisonelizabeth:ua/cloud_upgrade_link

Conversation

@alisonelizabeth
Copy link
Copy Markdown
Contributor

@alisonelizabeth alisonelizabeth commented Jan 27, 2022

Fixes #123943

This PR updates the upgrade guide doc links for both on-prem and cloud in Upgrade Assistant.

// Cloud
Screen Shot 2022-01-27 at 12 00 49 PM

// On prem
Screen Shot 2022-01-27 at 12 09 49 PM

@alisonelizabeth alisonelizabeth added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant v7.17.0 labels Jan 27, 2022
@alisonelizabeth alisonelizabeth changed the title [Upgrade Assistant] Update upgrade guide link [Upgrade Assistant] Update upgrade guide doc links Jan 27, 2022
alisonelizabeth
alisonelizabeth commented Jan 27, 2022
View reviewed changes
src/core/public/doc_links/doc_links_service.ts
elasticStackGetStarted: `${STACK_GETTING_STARTED}get-started-elastic-stack.html`,
upgrade: {
upgradingElasticStack: `${STACK_DOCS}upgrading-elastic-stack.html`,
upgradingStackOnPrem: `${ELASTIC_WEBSITE_URL}guide/en/elastic-stack/8.0/upgrading-elastic-stack-on-prem.html`,
Copy link
Copy Markdown
Contributor Author

@alisonelizabeth alisonelizabeth Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually be pointing to 8.0, not the current version. There is also a doc page now dedicated to on-prem.

alisonelizabeth
alisonelizabeth commented Jan 27, 2022
View reviewed changes
...ugins/upgrade_assistant/public/application/components/overview/upgrade_step/upgrade_step.tsx
iconType="popout"
>
{i18nTexts.upgradeStepLink}
{i18nTexts.upgradeGuideLink}
Copy link
Copy Markdown
Contributor Author

@alisonelizabeth alisonelizabeth Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed strange that we used different copy for the doc link on-prem ("Learn more") vs. cloud. Now the copy is the same in both places - "View upgrade guide".

@alisonelizabeth alisonelizabeth marked this pull request as ready for review January 27, 2022 18:02
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 27, 2022

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@cjcenizal cjcenizal self-requested a review January 27, 2022 18:05
debadair
debadair approved these changes Jan 27, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alisonelizabeth
Copy link
Copy Markdown
Contributor Author

alisonelizabeth commented Jan 27, 2022

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Copy Markdown
Contributor Author

alisonelizabeth commented Jan 27, 2022 •
edited
Loading

Test failure unrelated to this PR and was skipped via #123961

cjcenizal
cjcenizal approved these changes Jan 27, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code LGTM.

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jan 27, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 173.2KB 173.0KB -114.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 312.4KB 312.5KB +97.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth merged commit da12a45 into elastic:7.17 Jan 27, 2022
@alisonelizabeth alisonelizabeth deleted the ua/cloud_upgrade_link branch January 27, 2022 22:49
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Jan 28, 2022
@alisonelizabeth
[Upgrade Assistant] Update upgrade guide doc links (elastic#123953)
25e9149
@alisonelizabeth alisonelizabeth mentioned this pull request Jan 28, 2022
Merged
@cjcenizal cjcenizal mentioned this pull request Jan 28, 2022
Closed
alisonelizabeth added a commit that referenced this pull request Jan 31, 2022
@alisonelizabeth
[Upgrade Assistant] Update upgrade guide doc links (#123953) (#124029)
821f071
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Jan 31, 2022
@alisonelizabeth
[Upgrade Assistant] Update upgrade guide doc links (elastic#123953) (e…
f325c9a 
…lastic#124029)

(cherry picked from commit 821f071)
alisonelizabeth added a commit that referenced this pull request Jan 31, 2022
@alisonelizabeth
[Upgrade Assistant] Update upgrade guide doc links (#123953) (#124029) (
942426d 
#124128)

(cherry picked from commit 821f071)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@debadair debadair debadair approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.17.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alisonelizabeth @elasticmachine @kibana-ci @debadair @cjcenizal @kibanamachine