Skip to content

[Fixtures/Newsfeed] Server-side importing public types#123923

Merged
afharo merged 2 commits intoelastic:mainfrom
afharo:fixtures/newsfeed-import-from-server
Jan 27, 2022
Merged

[Fixtures/Newsfeed] Server-side importing public types#123923
afharo merged 2 commits intoelastic:mainfrom
afharo:fixtures/newsfeed-import-from-server

Conversation

@afharo
Copy link
Copy Markdown
Member

@afharo afharo commented Jan 27, 2022

Summary

It may fix #118572.

Please, advice on the backport strategy: is it OK to backport this fix this late in the dev process?

For maintainers

@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.1.0 labels Jan 27, 2022
@afharo afharo requested review from a team, liza-mae and spalger January 27, 2022 13:22
@afharo afharo added auto-backport Deprecated - use backport:version if exact versions are needed v7.17.0 v8.0.0 labels Jan 27, 2022
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, these are just types so I think it's fine to backport as far back as you like

@afharo afharo merged commit 7dedc88 into elastic:main Jan 27, 2022
@afharo afharo deleted the fixtures/newsfeed-import-from-server branch January 27, 2022 16:08
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 27, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 27, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.0
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 27, 2022
…3949)

(cherry picked from commit 7dedc88)

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
awahab07 pushed a commit to awahab07/kibana that referenced this pull request Jan 31, 2022
kibanamachine added a commit that referenced this pull request Feb 2, 2022
…3950)

(cherry picked from commit 7dedc88)

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v7.17.0 v8.0.0 v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newsfeed test fixture throwing fatal error on windows

4 participants