Skip to content

Reenable alert_add test suite #123862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zacqary merged 5 commits into from
Jan 27, 2022
Merged

Reenable alert_add test suite #123862

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0c5c0f0
Reenable alert_add test suite
Zacqary Jan 26, 2022
3e5cae4
Merge branch 'main' into 115396-testfix
kibanamachine Jan 26, 2022
28e3cc2
Merge branch 'main' into 115396-testfix
kibanamachine Jan 26, 2022
90aab57
Remove delays
Zacqary Jan 27, 2022
fe08ea1
Merge branch '115396-testfix' of https://github.com/Zacqary/kibana in…
Zacqary Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_add.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ const actionTypeRegistry = actionTypeRegistryMock.create();
const ruleTypeRegistry = ruleTypeRegistryMock.create();
const useKibanaMock = useKibana as jest.Mocked<typeof useKibana>;

const delay = (wait: number = 1000) =>
new Promise((resolve) => {
setTimeout(resolve, wait);
});

export const TestExpression: FunctionComponent<any> = () => {
return (
<EuiFormLabel>
Expand All @@ -64,8 +59,7 @@ export const TestExpression: FunctionComponent<any> = () => {
);
};

// FLAKY: https://github.com/elastic/kibana/issues/g
describe.skip('alert_add', () => {
describe('alert_add', () => {
let wrapper: ReactWrapper<any>;

async function setup(
Expand Down Expand Up @@ -179,7 +173,6 @@ describe.skip('alert_add', () => {
it('renders alert add flyout', async () => {
const onClose = jest.fn();
await setup({}, onClose);
await delay(1000);

expect(wrapper.find('[data-test-subj="addAlertFlyoutTitle"]').exists()).toBeTruthy();
expect(wrapper.find('[data-test-subj="saveAlertButton"]').exists()).toBeTruthy();
Expand Down Expand Up @@ -209,8 +202,6 @@ describe.skip('alert_add', () => {
onClose
);

await delay(1000);

expect(wrapper.find('input#alertName').props().value).toBe('Simple status alert');

expect(wrapper.find('[data-test-subj="tagsComboBox"]').first().text()).toBe('uptimelogs');
Expand Down Expand Up @@ -249,7 +240,6 @@ describe.skip('alert_add', () => {

it('should enforce any default inteval', async () => {
await setup({ alertTypeId: 'my-alert-type' }, jest.fn(), '3h');
await delay(1000);

// Wait for handlers to fire
await act(async () => {
Expand Down