Skip to content

Resolves errors preventing ES snapshot promotion#123649

Merged
tylersmalley merged 5 commits intoelastic:mainfrom
tylersmalley:test-unverified-snapshot
Jan 26, 2022
Merged

Resolves errors preventing ES snapshot promotion#123649
tylersmalley merged 5 commits intoelastic:mainfrom
tylersmalley:test-unverified-snapshot

Conversation

@tylersmalley
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley commented Jan 24, 2022

Issues:

  • ES archives created before 7.17.0 were run with 7.17.0 and re-saved so they can be opened in 8.0+
  • @kbn/es waits for a non-red status before setting up the native realm. Doing this too soon can lead to the node crashing.

Example updating an archive:

  • Start 7.17 instance with archive
KBN_ES_SNAPSHOT_USE_UNVERIFIED=true yarn es snapshot --version 7.17.0 --data-archive src/core/server/saved_objects/migrations/integration_tests/archives/7.14.0_xpack_sample_saved_objects.zip
  • Shutdown cluster once green
  • Update archive ("Extract path" from logs when ES started (
cd .es/7.17.0
zip -r ../../src/core/server/saved_objects/migrations/integration_tests/archives/7.14.0_xpack_sample_saved_objects.zip data

@tylersmalley tylersmalley force-pushed the test-unverified-snapshot branch from 563d73b to 56a1d44 Compare January 25, 2022 23:38
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley force-pushed the test-unverified-snapshot branch from 56a1d44 to 0258275 Compare January 25, 2022 23:40
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley force-pushed the test-unverified-snapshot branch 4 times, most recently from edd6231 to f15523e Compare January 26, 2022 06:19
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley force-pushed the test-unverified-snapshot branch 2 times, most recently from 1afdc63 to 01fca61 Compare January 26, 2022 07:21
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley force-pushed the test-unverified-snapshot branch from 01fca61 to b364ce9 Compare January 26, 2022 07:23
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley changed the title Testing unverified snapshot Resolves errors preventing ES snapshot promotion Jan 26, 2022
@tylersmalley tylersmalley added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v8.0.0 v8.1.0 labels Jan 26, 2022
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley marked this pull request as ready for review January 26, 2022 15:52
@tylersmalley tylersmalley requested review from a team as code owners January 26, 2022 15:52
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley tylersmalley enabled auto-merge (squash) January 26, 2022 15:54
export BUILD_TS_REFS_DISABLE=true
export DISABLE_BOOTSTRAP_VALIDATION=true

export TEST_KIBANA_HOST=localhost
Copy link
Copy Markdown
Member Author

@tylersmalley tylersmalley Jan 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianseeders can these be safely removed, or are they still required in the Buildkite world?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like TEST_PROXY_SERVER_PORT may be in use in integration tests. cc @TinaHeiligers

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure honestly, but I think if you get a green build you should be good to remove them.

Copy link
Copy Markdown
Member Author

@tylersmalley tylersmalley Jan 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like those are all part of Jest Integration tests, so should be good.

@tylersmalley tylersmalley merged commit a80acbb into elastic:main Jan 26, 2022
@tylersmalley tylersmalley deleted the test-unverified-snapshot branch January 26, 2022 16:11
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.0 Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 123649

Questions ?

Please refer to the Backport tool documentation

tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Jan 26, 2022
(cherry picked from commit a80acbb)

# Conflicts:
#	src/core/server/saved_objects/migrations/integration_tests/batch_size_bytes_exceeds_es_content_length.test.ts
jbudz pushed a commit to jbudz/kibana that referenced this pull request Jan 27, 2022
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v8.0.0 v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants