Skip to content

[8.0] tooltip added to OS column (#123377) #123631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
semd merged 2 commits into from
Jan 24, 2022
Merged

[8.0] tooltip added to OS column (#123377) #123631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7256aad
tooltip added to OS column (#123377)
semd Jan 24, 2022
d4512b4
remove not needed translation
semd Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion x-pack/plugins/security_solution/public/hosts/components/hosts_table/columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,13 @@ export const getHostsColumns = (): HostsTableColumns => [
},
{
field: 'node.host.os.name',
name: i18n.OS,
name: (
<EuiToolTip content={i18n.OS_LAST_SEEN_TOOLTIP}>
<>
{i18n.OS} <EuiIcon color="subdued" type="iInCircle" className="eui-alignTop" />
</>
</EuiToolTip>
),
truncateText: false,
hideForMobile: false,
sortable: false,
Expand Down
7 changes: 7 additions & 0 deletions x-pack/plugins/security_solution/public/hosts/components/hosts_table/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@ export const FIRST_LAST_SEEN_TOOLTIP = i18n.translate(
}
);

export const OS_LAST_SEEN_TOOLTIP = i18n.translate(
'xpack.securitySolution.hostsTable.osLastSeenToolTip',
{
defaultMessage: 'Most recently observed OS',
}
);

export const OS = i18n.translate('xpack.securitySolution.hostsTable.osTitle', {
defaultMessage: 'Operating system',
});
Expand Down