[Discover] Create data view from sidebar

[majagrubic]

Summary

Closes: #111158

This PR adds "Create new data view" option from the existing data view actions dropdown in Discover.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  - [ ] Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
  ~- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[majagrubic]

@elasticmachine merge upstream

[kertal]

@elasticmachine merge upstream

[kertal]

Tested a-la-carte and works as expected, Safari, Chrome, it's a great addition! 🥳
One question, shouldn't we start with this action in the popover?

1. create a data view, 2. add a field, 3. manage fields .... that order feels better to me subjectively, because it's what u usually do in case you wanna create a data view.

[kertal]

@elasticmachine merge upstream

[majagrubic]

@kertal think this was originally introduced to make addition/editing of runtime fields easier. in my opinion, that's the primary use of the dropdown, and creating a data view is just a bonus. but I'll let @ryankeairns weigh in on this one.

[majagrubic]

@elasticmachine merge upstream

[ryankeairns]

The way I 'read' it, you are currently in a selected data view. I would start with the actions that pertain to the current state/selection, then lastly place the option to change the state (i.e. create a new data view)

To that point, I would even add a divider after the top two actions.

Here is an example of the divider usage in Canvas:

[majagrubic]

@elasticmachine merge upstream

[ryankeairns]

Thanks for adding this. After reviewing the UI changes, I would like to request a few changes. These also align with the forthcoming Unified Search efforts.

---

👉 These can be found in this design PR and merged at your convenience: majagrubic#5

---

1. Add a title (to avoid redundant use of 'data view' text in each link)
2. Update link text/copy
3. Remove padding
4. Increase panel size from s to m

[ryankeairns]

Thanks for merging the design changes.

[kertal]

ACK but won't make it to start a final test today ... qq: should't this be 8.2. ... to walk hand in hand with adding it to Lens?

[majagrubic]

I don't see a reason why it wouldn't make 8.1, but if you think it makes more sense to wait for 8.2, that's fine as well.

[kertal]

LGTM, this is super-nice, with the latest changes there's also a clear structure. Great work!
So about 8.1 or 8.2 ... from Discover side 8.1 @shaunmcgough ... only I wonder if we should align with Lens, which will follow in 8.2, right @ghudgins @flash1293

[majagrubic]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: e09e56d
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
discover	330.4KB	331.2KB	+816.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
discover	51.6KB	51.6KB	+32.0B

History

• 💚 Build #20422 succeeded af015c7
• 💔 Build #20408 failed b8f60f8
• 💚 Build #20131 succeeded 8301f86
• 💚 Build #19973 succeeded 447d853
• 💔 Build #19961 failed 60f7a19
• 💚 Build #19838 succeeded b2ee2fb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

💔 All backports failed

Status	Branch	Result
❌	7.17	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 123391

Questions ?

Please refer to the Backport tool documentation