[maps] fix Unable to load layers from WMS capabilities for a specific URL#123386
Merged
nreese merged 4 commits intoelastic:mainfrom Feb 1, 2022
Merged
[maps] fix Unable to load layers from WMS capabilities for a specific URL#123386nreese merged 4 commits intoelastic:mainfrom
nreese merged 4 commits intoelastic:mainfrom
Conversation
nreese
added
release_note:fix
v8.0.0
auto-backport
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flakyTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
nickpeihl
approved these changes
Jan 31, 2022
Contributor
nickpeihl
left a comment
nickpeihl
left a comment
There was a problem hiding this comment.
lgtm!
code review and tested in chrome.
nreese
added
the
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 1, 2022
… URL (elastic#123386) * [maps] fix Unable to load layers from WMS spec for a specific URL * eslint Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit d7bce1c)
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 1, 2022
… URL (elastic#123386) * [maps] fix Unable to load layers from WMS spec for a specific URL * eslint Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit d7bce1c)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122957
https://datacarto.datara.gouv.fr/wms capabilities returns results where
layer.Nameis not provided. The logic tried to read fromlayer.Nameand this return the error seen in the screen shot from the issue. The fix is to wrap reading with_.getso an empty string is returned if the element does not exist.