[SecuritySolution][Hosts] All hosts table OS column tooltip#123377
Merged
semd merged 3 commits intoelastic:mainfrom Jan 24, 2022
Merged
[SecuritySolution][Hosts] All hosts table OS column tooltip#123377semd merged 3 commits intoelastic:mainfrom
semd merged 3 commits intoelastic:mainfrom
Conversation
semd
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Contributor
Author
|
@elasticmachine merge upstream |
|
hey @semd, overall the design of the tooltip and interaction itself is all good. The only thing I want to doublecheck is the actual working of the message in the tooltip.
I would ask for some feedback from the docs team about the message |
stephmilovic
approved these changes
Jan 20, 2022
Contributor
stephmilovic
left a comment
stephmilovic
left a comment
There was a problem hiding this comment.
Simple solution, I like it. Please just fix the spelling as @monina-n requested and LGTM
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @semd |
Contributor
💔 All backports failed
How to fixRe-run the backport manually: Questions ?Please refer to the Backport tool documentation |
This was referenced Jan 24, 2022
semd
added a commit
to semd/kibana
that referenced
this pull request
Jan 24, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit e76cedb) # Conflicts: # x-pack/plugins/security_solution/public/hosts/components/hosts_table/columns.tsx # x-pack/plugins/security_solution/public/hosts/components/hosts_table/translations.ts
semd
added a commit
that referenced
this pull request
Jan 24, 2022
* tooltip added to OS column (#123377) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit e76cedb) # Conflicts: # x-pack/plugins/security_solution/public/hosts/components/hosts_table/columns.tsx # x-pack/plugins/security_solution/public/hosts/components/hosts_table/translations.ts * remove not needed translation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issue: #122205
The Operating System fields (
os.name,os.version, ...) fields can be multi-valuated once aggregated byhost.name. Currently, we are displaying the most recent value.A tooltip has been added to the Hosts table column header, to inform users that the OS data displayed is the most recent.