Conversation
|
WIP until I have tests covering falling back to v5 indices when v6 fails. Queries should be good to review. |
There was a problem hiding this comment.
This might be an appropriate time to make a function to handle the returned object from these methods.
|
Make sure to cover
More details here: #10858 |
There was a problem hiding this comment.
Looks like you need to also export getDocType
afda663 to
e38d445
Compare
|
@jbudz Might want to update the template to set strict mappings |
|
Getting an error prior to the re-index on bulkCreate when used through the dashboard importer. To reproduce: if you don't have a Metricbeat-filesystem dashboard, swap out the query param |
There was a problem hiding this comment.
We can add an option to define the format to use and default to v6. If it fails, we can re-call bulkCreate with v5 if it's v6.
We can also create a module for each formatting helpers.
|
Will re-open with changes. |
This adds a compatibility layer to the saved objects client allowing it to support and return the same responses for crud operations on kibana indices under a single type(6,) and kibana indices using multiple types v(4,5)
To test, create v6 mappings:
Reindex:
Set kibana.index to .kibana-6.
The server will error until everything is switched over to use the api, but endpoints should be available. Test cases detailed in the saved objects pr should behave the same.