Skip to content

D/2022 01 18 data deps add security logs#123220

Closed
Dosant wants to merge 24 commits intoelastic:mainfrom
Dosant:d/2022-01-18-data-deps-add-security-logs
Closed

D/2022 01 18 data deps add security logs#123220
Dosant wants to merge 24 commits intoelastic:mainfrom
Dosant:d/2022-01-18-data-deps-add-security-logs

Conversation

@Dosant
Copy link
Copy Markdown
Contributor

@Dosant Dosant commented Jan 18, 2022

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Jan 18, 2022

@Dosant Dosant force-pushed the d/2022-01-18-data-deps-add-security-logs branch from df4f406 to 98c71aa Compare January 19, 2022 14:21
@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Jan 19, 2022

@elasticmachine merge upstream

@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Jan 20, 2022

@elasticmachine merge upstream

@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Jan 24, 2022

@elasticmachine merge upstream

@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Jan 25, 2022

@elasticmachine merge upstream

@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Jan 25, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
home 9.9KB 9.8KB -9.0B
security 50.1KB 50.1KB -9.0B
total -18.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
customIntegrations 2 3 +1

References to deprecated APIs

id before after diff
home 1 0 -1
security 55 54 -1
total -2

Total ESLint disabled count

id before after diff
customIntegrations 2 3 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants