[Discover] Fix page up and down navigation in classic table#122742
Merged
kertal merged 5 commits intoelastic:mainfrom Jan 13, 2022
Merged
[Discover] Fix page up and down navigation in classic table#122742kertal merged 5 commits intoelastic:mainfrom
kertal merged 5 commits intoelastic:mainfrom
Conversation
kertal
added
Feature:Discover
kertal
commented
Jan 12, 2022
src/plugins/discover/public/application/main/components/layout/discover_documents.tsx
Show resolved
Hide resolved
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Member
Author
|
@elasticmachine merge upstream |
…f github.com:kertal/kibana into kertal-pr-2022-01-12-fix-page-up-and-down-navigation
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @kertal |
majagrubic
approved these changes
Jan 13, 2022
Contributor
majagrubic
left a comment
majagrubic
left a comment
There was a problem hiding this comment.
Code review only, haven't tested it
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the broken Page UP and Page Down navigation in classic table. Since we had to modify the table's container element to be no longer a focusable element, when using the "Back to top" button when reaching the end of the scrolling table is focusing the "Go to end of the table" button.
Testing
If you use a MacBook you can use
fn + arrow upandfn + arrow downto test this. Before this PR it didn't work, you just got the container element focus (and a black border)Fixes #120180
Checklist