Skip to content

[7.17] [Index Management] Improve error messages when editing index settings (#119144)#121724

Merged
sabarasaba merged 2 commits intoelastic:7.17from
sabarasaba:backport/7.17/pr-119144
Dec 21, 2021
Merged

[7.17] [Index Management] Improve error messages when editing index settings (#119144)#121724
sabarasaba merged 2 commits intoelastic:7.17from
sabarasaba:backport/7.17/pr-119144

Conversation

@sabarasaba
Copy link
Member

Backports the following commits to 7.17:

…elastic#119144)

* Improve error message and start writting tests

* Refactor tests

* Fix tests

* commit using @elastic.co

* Refactor test

* Add documentation

* Fix ts types

* Address CR changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/index_management/__jest__/client_integration/helpers/test_subjects.ts
#	x-pack/plugins/index_management/public/application/sections/home/index_list/detail_panel/edit_settings_json/edit_settings_json.js
@sabarasaba sabarasaba added the backport This PR is a backport of another PR label Dec 21, 2021
@sabarasaba sabarasaba enabled auto-merge (squash) December 21, 2021 07:16
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 524.9KB 525.0KB +132.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sabarasaba sabarasaba merged commit 5975bae into elastic:7.17 Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants