[Security Solution] Resolver, revert to default data view#121711
Merged
stephmilovic merged 2 commits intoelastic:mainfrom Dec 21, 2021
Merged
[Security Solution] Resolver, revert to default data view#121711stephmilovic merged 2 commits intoelastic:mainfrom
stephmilovic merged 2 commits intoelastic:mainfrom
Conversation
stephmilovic
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
kqualters-elastic
approved these changes
Dec 20, 2021
Contributor
kqualters-elastic
left a comment
kqualters-elastic
left a comment
There was a problem hiding this comment.
tested locally, works as before. lgtm 👍
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 21, 2021
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Dec 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #120859
In the 8.0 sourcerer upgrade, we started getting the Resolver data view from the
sourcerer.sourcererScopes.timeline.selectedPatternsand this introduced a bug. We used to get it from a mix of the default index patterns and the signals index. This is what the value ofsourcerer.defaultDataView.patternListis. Therefore, in non-timeline Resolver views when the Timeline data view is changed to something likemetrics-*that would not match any Resolver events, these views would break.I added logic to only use the
sourcerer.sourcererScopes.timeline.selectedPatternswhen GraphOverlayisInTimeline=trueand use the default data view patternList otherwise. However, there will still be a bug if a user makes an Endpoint rule for indices not in the default pattern. This bug existed prior to the 8.0 sourcerer upgrade, and due to holidays/feature freeze I will only be fixing the new bug introduced by the 8.0 sourcerer upgrade upgrade.Checklist
Delete any items that are not applicable to this PR.