Skip to content

Revert "disable save button if visualization is dirty (#11576)" #12152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2017
Merged

Revert "disable save button if visualization is dirty (#11576)" #12152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/core_plugins/kibana/public/visualize/editor/editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,6 @@ function VisEditor($rootScope, $scope, $route, timefilter, AppState, $window, kb
description: 'Save Visualization',
template: require('plugins/kibana/visualize/editor/panels/save.html'),
testId: 'visualizeSaveButton',
disableButton() {
return Boolean(editableVis.dirty);
},
tooltip() {
if (editableVis.dirty) {
return 'Apply or Discard your changes before saving';
}
}
}, {
key: 'share',
description: 'Share Visualization',
Expand Down
59 changes: 0 additions & 59 deletions test/functional/apps/visualize/_editor.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion test/functional/apps/visualize/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export default function ({ getService, loadTestFile }) {
});
});

loadTestFile(require.resolve('./_editor'));
loadTestFile(require.resolve('./_chart_types'));
loadTestFile(require.resolve('./_gauge_chart'));
loadTestFile(require.resolve('./_area_chart'));
Expand Down
6 changes: 0 additions & 6 deletions test/functional/page_objects/visualize_page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,12 +402,6 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
}


async isSaveButtonEnabled() {
const saveButton = await testSubjects.find('visualizeSaveButton');
const clazz = await saveButton.getProperty('className');
return clazz.indexOf('kuiLocalMenuItem-isDisabled') === -1;
}

saveVisualization(vizName) {
return testSubjects.click('visualizeSaveButton')
.then(() => {
Expand Down