Skip to content

[RAC] fix the alerts table hidden rows due to miscalculated height #121399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ersin-erdal wants to merge 4 commits into from
Closed

[RAC] fix the alerts table hidden rows due to miscalculated height #121399

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4615fec
[RAC] fix the alerts table hidden rows due to miscalculated height
ersin-erdal Dec 16, 2021
9737d1f
Merge branch 'main' of https://github.com/elastic/kibana into 119310-…
ersin-erdal Jan 10, 2022
d015c4c
use the new row height (28)
ersin-erdal Jan 10, 2022
af0a3d7
Merge branch 'main' into 119310-alerts-table-height-hack
kibanamachine Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 16 additions & 42 deletions x-pack/plugins/timelines/public/components/t_grid/body/height_hack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,66 +7,40 @@

import { useState, useLayoutEffect } from 'react';

// It will recalculate DataGrid height after this time interval.
const TIME_INTERVAL = 50;

/**
* You are probably asking yourself "Why 3?". But that is the wrong mindset. You should be asking yourself "why not 3?".
* 3 (three) is a number, numeral and digit. It is the natural number following 2 and preceding 4, and is the smallest
* odd prime number and the only prime preceding a square number. It has religious or cultural significance in many societies.
*/

const MAGIC_GAP = 3;

// Hard coded height for every page size
// rowHeight * pageSize + (filtersHeight + headerHeight + paginationHeight + 1)
// +1 is for useLayoutEffect to detect the change
const DATA_GRID_HEIGHT_BY_PAGE_SIZE: { [key: number]: number } = {
10: 457,
25: 967,
50: 1817,
100: 3517,
10: 389,
25: 809,
50: 1509,
100: 2909,
};

/**
* HUGE HACK!!!
* DataGrtid height isn't properly calculated when the grid has horizontal scroll.
* DataGrid height isn't properly calculated when the grid has horizontal scroll.
* https://github.com/elastic/eui/issues/5030
*
* In order to get around this bug we are calculating `DataGrid` height here and setting it as a prop.
*
* Please delete me and allow DataGrid to calculate its height when the bug is fixed.
*/

const dataGridRowHeight = 36;
const headerSectionHeight = 32;
const additionalFiltersHeight = 44;
const filtersHeight = 32;
const headerHeight = 40;
const paginationHeight = 36;
Copy link
Copy Markdown
Contributor Author

@ersin-erdal ersin-erdal Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added even if there is no pagination, but since it occupies the whole page, having a gap under the table is ok.

const rowHeight = 28;

export const useDataGridHeightHack = (pageSize: number, rowCount: number) => {
const [height, setHeight] = useState(DATA_GRID_HEIGHT_BY_PAGE_SIZE[pageSize]);

useLayoutEffect(() => {
setTimeout(() => {
const gridVirtualized = document.querySelector('#body-data-grid .euiDataGrid__virtualized');

if (rowCount === pageSize) {
setHeight(DATA_GRID_HEIGHT_BY_PAGE_SIZE[pageSize]);
} else if (rowCount <= pageSize) {
// This is unnecessary if we add rowCount > pageSize below
setHeight(dataGridRowHeight * rowCount + (headerSectionHeight + additionalFiltersHeight));
} else if (
// rowCount > pageSize && // This will fix the issue but is always full height so has a lot of empty state
gridVirtualized &&
gridVirtualized.children[0].clientHeight !== gridVirtualized.clientHeight // check if it has vertical scroll
) {
setHeight((currHeight) => {
return (
currHeight +
gridVirtualized.children[0].clientHeight -
gridVirtualized.clientHeight +
MAGIC_GAP
);
});
}
}, TIME_INTERVAL);
if (rowCount < pageSize) {
setHeight(rowHeight * rowCount + (headerHeight + filtersHeight + paginationHeight));
} else {
setHeight(DATA_GRID_HEIGHT_BY_PAGE_SIZE[pageSize]);
}
}, [pageSize, rowCount]);

return height;
Expand Down