Skip to content

[Security Solution] Clean up legacy siem.signals tasks on upgrade#121257

Closed
madirey wants to merge 5 commits intoelastic:mainfrom
madirey:disable-rule-on-upgrade
Closed

[Security Solution] Clean up legacy siem.signals tasks on upgrade#121257
madirey wants to merge 5 commits intoelastic:mainfrom
madirey:disable-rule-on-upgrade

Conversation

@madirey
Copy link
Copy Markdown
Contributor

@madirey madirey commented Dec 15, 2021

Summary

Fixes part of https://github.com/elastic/security-team/issues/2344 and #120906

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@madirey madirey added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Dec 15, 2021
@madirey madirey changed the title Disable rule on upgrade [Security Solution] Clean up legacy siem.signals tasks on upgrade Dec 15, 2021
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@madirey madirey closed this Dec 16, 2021
@madirey
Copy link
Copy Markdown
Contributor Author

madirey commented Dec 16, 2021

Closed in favor of: #121442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants