Skip to content

[TypeScript] Upgrade to 4.5.3#120812

Merged
brianseeders merged 15 commits intoelastic:mainfrom
brianseeders:ts-4-5-2
Dec 13, 2021
Merged

[TypeScript] Upgrade to 4.5.3#120812
brianseeders merged 15 commits intoelastic:mainfrom
brianseeders:ts-4-5-2

Conversation

@brianseeders
Copy link
Contributor

@brianseeders brianseeders commented Dec 8, 2021 •
edited
Loading

Upgrades TypeScript to the latest version.

See #121003 for the isEditable issue

@brianseeders brianseeders added Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes v8.1.0 Team:Operations Kibana-Operations Team labels Dec 8, 2021
@elastic elastic deleted a comment from kibana-ci Dec 8, 2021
@brianseeders brianseeders added the backport:skip This PR does not require backporting label Dec 9, 2021
@brianseeders brianseeders marked this pull request as ready for review December 9, 2021 20:22
@brianseeders brianseeders requested a review from a team December 9, 2021 20:22
@brianseeders brianseeders requested review from a team as code owners December 9, 2021 20:22
@ThomThomson ThomThomson mentioned this pull request Dec 9, 2021
Closed
ThomThomson
ThomThomson approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team changes LGTM! Thank you for ignoring the TS errors. I have created an issue to track our TODO to update those files.

@tylersmalley
Copy link
Member

tylersmalley commented Dec 9, 2021 •
edited
Loading

35% faster?! Yes, please!

Running: yarn kbn clean; BUILD_TS_REFS_DISABLE=true yarn kbn bootstrap; time node scripts/build_ts_refs.js --no-cache

ts-4-5-2:

info [tsc] exited with 0 after 535.9 seconds

main:

info [tsc] exited with 0 after 765.4 seconds

jportner
jportner approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

mistic
mistic approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mshustov
mshustov approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@mshustov mshustov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for the Core changes.
Please note the current PR updates TS to v4.5 but developers can't use some new TypeScript features until other code analysis tools are updated to versions with TypeScript v4.5 support:
https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.6.0
https://github.com/babel/babel/releases/tag/v7.16.0
https://prettier.io/blog/2021/11/25/2.5.0.html

juliaElastic
juliaElastic approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet change LGTM

peteharverson
peteharverson approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transform change LGTM

yuliacech
yuliacech approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any of Stack Management plugins changed so approving to unblock the merging

janmonschke
janmonschke reviewed Dec 13, 2021
View reviewed changes
x-pack/plugins/security_solution/public/common/components/auto_download/auto_download.tsx
useEffect(() => {
if (blob && anchorRef?.current) {
// @ts-expect-error
if (typeof window.navigator.msSaveOrOpenBlob === 'function') {
Copy link
Contributor

@janmonschke janmonschke Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the PR: we should probably not ship this code anymore since it's an API that was just supported by Internet Explorer. (takes a mental note to create a follow-up PR)

janmonschke
janmonschke approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@janmonschke janmonschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brianseeders brianseeders changed the title [TypeScript] Upgrade to 4.5.2 [TypeScript] Upgrade to 4.5.3 Dec 13, 2021
justinkambic
justinkambic approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM!

@kibana-ci
Copy link

kibana-ci commented Dec 13, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1013.2KB 1013.2KB -1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@brianseeders brianseeders merged commit 16af3e6 into elastic:main Dec 13, 2021
@brianseeders brianseeders mentioned this pull request Dec 13, 2021
Merged
@brianseeders brianseeders deleted the ts-4-5-2 branch December 13, 2021 21:54
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@brianseeders @TinLe
[TypeScript] Upgrade to 4.5.3 (elastic#120812)
834dc71
@cee-chen cee-chen mentioned this pull request Feb 2, 2022
Merged
3 tasks
mistic pushed a commit to mistic/kibana that referenced this pull request Jun 1, 2023
@brianseeders
[TypeScript] Upgrade to 4.5.3 (elastic#120812)
d733245 
(cherry picked from commit 16af3e6)

# Conflicts:
#	package.json
#	src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx
#	x-pack/plugins/canvas/public/components/workpad_header/editor_menu/editor_menu.tsx
#	x-pack/plugins/security_solution/public/management/pages/policy/store/policy_details/middleware/policy_trusted_apps_middleware.ts
@mistic mistic mentioned this pull request Jun 1, 2023
Merged
mistic added a commit that referenced this pull request Jun 1, 2023
@mistic @brianseeders
[7.17] [TypeScript] Upgrade to 4.5.3 (#120812) (#158883)
6f5ea2c 
# Backport

This will backport the following commits from `main` to `7.17`:
- [[TypeScript] Upgrade to 4.5.3
(#120812)](#120812)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Brian
Seeders","email":"brian.seeders@elastic.co"},"sourceCommit":{"committedDate":"2021-12-13T17:54:17Z","message":"[TypeScript]
Upgrade to 4.5.3
(#120812)","sha":"16af3e612d27bd3608787a3daab121d648787f67","branchLabelMapping":{"^v8.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","Feature:Embedding","Team:APM","release_note:skip","Feature:CI","backport:skip","Team:Fleet","v8.1.0"],"number":120812,"url":"https://github.com/elastic/kibana/pull/120812","mergeCommit":{"message":"[TypeScript]
Upgrade to 4.5.3
(#120812)","sha":"16af3e612d27bd3608787a3daab121d648787f67"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.1.0","labelRegex":"^v8.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/120812","number":120812,"mergeCommit":{"message":"[TypeScript]
Upgrade to 4.5.3
(#120812)","sha":"16af3e612d27bd3608787a3daab121d648787f67"}}]}]
BACKPORT-->

Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@janmonschke janmonschke janmonschke approved these changes

@nreese nreese nreese approved these changes

@jbudz jbudz jbudz approved these changes

@mistic mistic mistic approved these changes

@peteharverson peteharverson peteharverson approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

@justinkambic justinkambic justinkambic approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@juliaElastic juliaElastic juliaElastic approved these changes

@vigneshshanmugam vigneshshanmugam Awaiting requested review from vigneshshanmugam

@dasansol92 dasansol92 Awaiting requested review from dasansol92 dasansol92 was automatically assigned from elastic/security-onboarding-and-lifecycle-mgt

+5 more reviewers

@academo academo academo approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

@mshustov mshustov mshustov approved these changes

@jportner jportner jportner approved these changes

@yuliacech yuliacech yuliacech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:CI Continuous integration Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Fleet Team label for Observability Data Collection Fleet team Team:Operations Kibana-Operations Team v7.17.11 v8.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.