Skip to content

[8.0] [Security Solution] Switches remaining rule types to use new Rule Preview API (#116374)#120700

Merged
dplumlee merged 3 commits intoelastic:8.0from
dplumlee:backport/8.0/pr-116374
Dec 8, 2021
Merged

[8.0] [Security Solution] Switches remaining rule types to use new Rule Preview API (#116374)#120700
dplumlee merged 3 commits intoelastic:8.0from
dplumlee:backport/8.0/pr-116374

Conversation

@dplumlee
Copy link
Contributor

@dplumlee dplumlee commented Dec 7, 2021

Backports the following commits to 8.0:

…view API (elastic#116374)

# Conflicts:
#	x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/preview_rules_route.ts
@dplumlee dplumlee added the backport This PR is a backport of another PR label Dec 7, 2021
@dplumlee dplumlee enabled auto-merge (squash) December 7, 2021 23:41
@dplumlee
Copy link
Contributor Author

dplumlee commented Dec 8, 2021

@elasticmachine merge upstream

@dplumlee dplumlee merged commit 32ff2d1 into elastic:8.0 Dec 8, 2021
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2806 2797 -9

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
ruleRegistry 145 148 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.5MB -9.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 244.6KB 244.2KB -326.0B
Unknown metric groups

API count

id before after diff
ruleRegistry 171 175 +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dplumlee dplumlee deleted the backport/8.0/pr-116374 branch December 8, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants