When on an embedded page, bypass Getting Started gate check#12040
Merged
ycombinator merged 2 commits intoelastic:masterfrom May 26, 2017
Merged
When on an embedded page, bypass Getting Started gate check#12040ycombinator merged 2 commits intoelastic:masterfrom
ycombinator merged 2 commits intoelastic:masterfrom
Conversation
ycombinator
added
Feature:Dashboard
stacey-gammon
approved these changes
May 26, 2017
stacey-gammon
left a comment
stacey-gammon
left a comment
There was a problem hiding this comment.
LGTM, embedded dashboards now work with the fix. Thanks!
ycombinator
added a commit
that referenced
this pull request
May 26, 2017
* When on an embedded page, bypass Getting Started gate check * Add unit test for embedded page scenario
Contributor
Author
|
Backported to:
|
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
…12040) * When on an embedded page, bypass Getting Started gate check * Add unit test for embedded page scenario
ycombinator
added a commit
to ycombinator/kibana
that referenced
this pull request
Jun 3, 2017
…lastic#12040)" This reverts commit 05293f1.
ycombinator
added a commit
that referenced
this pull request
Jun 5, 2017
* Revert "When on an embedded page, bypass Getting Started gate check (#12040)" This reverts commit 05293f1. * Revert "Making tweaks. (#12003)" This reverts commit aa3fa06. * Revert "Functional tests for the Getting Started page (#11850)" This reverts commit 099178a. * Revert "Prevent flicker on Getting Started page (#11826)" This reverts commit c4b3ade. * Revert "Getting Started page (#11805)" This reverts commit 32eff37. * Remove check for Getting Started page from navigateToApp
ycombinator
added a commit
that referenced
this pull request
Jun 5, 2017
* Revert "When on an embedded page, bypass Getting Started gate check (#12040)" This reverts commit 05293f1. * Revert "Making tweaks. (#12003)" This reverts commit aa3fa06. * Revert "Functional tests for the Getting Started page (#11850)" This reverts commit 099178a. * Revert "Prevent flicker on Getting Started page (#11826)" This reverts commit c4b3ade. * Revert "Getting Started page (#11805)" This reverts commit 32eff37. * Remove check for Getting Started page from navigateToApp
PopradiArpad
pushed a commit
to PopradiArpad/kibana
that referenced
this pull request
Jun 6, 2017
* Revert "When on an embedded page, bypass Getting Started gate check (elastic#12040)" This reverts commit 05293f1. * Revert "Making tweaks. (elastic#12003)" This reverts commit aa3fa06. * Revert "Functional tests for the Getting Started page (elastic#11850)" This reverts commit 099178a. * Revert "Prevent flicker on Getting Started page (elastic#11826)" This reverts commit c4b3ade. * Revert "Getting Started page (elastic#11805)" This reverts commit 32eff37. * Remove check for Getting Started page from navigateToApp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12039
When viewing an embedded page (such as an embedded dashboard or visualization) the Getting Started gate check is unnecessary; we should show users exactly what they asked for. So this check should return early.