Typo in panels.asciidoc #1202
Merged
Typo in panels.asciidoc #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s/hover/however/
This was referenced Apr 27, 2021
edmarmoretti
pushed a commit
to edmarmoretti/kibana-pt-br
that referenced
this pull request
Sep 7, 2025
This commit discontinues the very large dimensions used for patterns; improves types; removes hundreds of lines; increases efficiency eg. by pre-transforming textures, upping O() and culling canvas2d API calls; code readability improvs eg. brevity and names; partial fix elastic#1202 BREAKING CHANGE: - `TextStyle.fontStyle` is no longer a `string`, it's the more specific `FontStyle` - For symmetry, `fontStyle` in word cloud is also switching from `string` to `FontStyle` - Certain text configurations included both `fill` and `textColor` for the text color; `fill` got removed, because `textColor` is part of the public `Font` type, and because `textColor` has clearer meaning than `fill`. Yet, some of the code used the `fill` property and/or made the `fill` property also mandatory. So, userland code needs to remove some `fill` property, and might need to ensure that the correct value is going into `textColor` - `getRadians` got unpublished - No attempt to draw a rect border if there's not enough width/height for at least the specified border width (ie. width/height being at least twice the border width)
edmarmoretti
pushed a commit
to edmarmoretti/kibana-pt-br
that referenced
this pull request
Sep 7, 2025
# [34.0.0](elastic/elastic-charts@v33.2.4...v34.0.0) (2021-08-16) ### Code Refactoring * **cartesian:** cartesian rendering iteration ([elastic#1286](elastic/elastic-charts#1286)) ([b2ae4f7](elastic/elastic-charts@b2ae4f7)), closes [elastic#1202](elastic/elastic-charts#1202) ### BREAKING CHANGES * **cartesian:** - `TextStyle.fontStyle` is no longer a `string`, it's the more specific `FontStyle` - For symmetry, `fontStyle` in word cloud is also switching from `string` to `FontStyle` - Certain text configurations included both `fill` and `textColor` for the text color; `fill` got removed, because `textColor` is part of the public `Font` type, and because `textColor` has clearer meaning than `fill`. Yet, some of the code used the `fill` property and/or made the `fill` property also mandatory. So, userland code needs to remove some `fill` property, and might need to ensure that the correct value is going into `textColor` - `getRadians` got unpublished - No attempt to draw a rect border if there's not enough width/height for at least the specified border width (ie. width/height being at least twice the border width)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s/hover/however/