Skip to content

Comments

[Upgrade Assistant] Remove index_mapper_dynamic setting when reindexing#119441

Merged
sabarasaba merged 2 commits intoelastic:7.16from
sabarasaba:ua/remove_index_mapper_dynamic_settings
Nov 23, 2021
Merged

[Upgrade Assistant] Remove index_mapper_dynamic setting when reindexing#119441
sabarasaba merged 2 commits intoelastic:7.16from
sabarasaba:ua/remove_index_mapper_dynamic_settings

Conversation

@sabarasaba
Copy link
Member

Summary

As surfaced by #116212, when updating from 5.5 to 6.20 to 7.16 and attempting to reindex .reindexed-v6-kibana-6 users get an error saying Setting index.mapper.dynamic was removed after version 6.0.0. This is a manual deprecation that needs to be solved before running the reindex process. Turns out that within the UA reindexing code there's a list of blacklisted settings that get removed before the reindexing runs and this particular setting, that was removed with elasticsearch#51718, is not there.

How to test

  1. Unzip 5.5-data-snapshot.zip and start up ES as follows: yarn es snapshot -E path.data=/path/to/5.5-data-snapshot. This contains indices from 5.5 that where migrated to 6.8 and then to 7.16.
  2. Navigate to Stack Management -> Upgrade Assistant -> ES deprecation issues
  3. Verify that for .reindexed-v6-kibana-6 there are two critical deprecations: Index created before 7.0 and Setting [index.mapper.dynamic] is deprecated
  4. Open the Index created before 7.0 deprecation and verify that it can be successfully re-indexed
  5. Verify after clicking the Refresh CTA from the ES deprecation issues page, the Setting [index.mapper.dynamic] is deprecated deprecation is gone.

If after following the steps you don't see any deprecations for es in upgrade assistant, try unzipping the folder in the kibana/.es folder and starting up es with: yarn es snapshot -E path.data=../5.5-data-snapshot

Screenshots

before/after

// With error
138763612-18f03d01-5058-44e5-a160-80438561f794

// Solved deprecation
141445459-42814480-3a15-4e98-a3eb-6b2d0f86446c

@sabarasaba sabarasaba added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant v7.16.1 labels Nov 23, 2021
@sabarasaba sabarasaba requested a review from sebelga November 23, 2021 10:45
@sabarasaba sabarasaba self-assigned this Nov 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works as expected! Great job @sabarasaba 👍

@sabarasaba sabarasaba merged commit 872a718 into elastic:7.16 Nov 23, 2021
sabarasaba added a commit to sabarasaba/kibana that referenced this pull request Nov 24, 2021
…ng (elastic#119441)

* Add index_mapper_dynamic to removeList

* commit using @elastic.co
sabarasaba added a commit to sabarasaba/kibana that referenced this pull request Nov 24, 2021
…ng (elastic#119441)

* Add index_mapper_dynamic to removeList

* commit using @elastic.co
sabarasaba added a commit that referenced this pull request Nov 24, 2021
…emove duped copy from header (#119569)

* [Upgrade Assistant] Remove index_mapper_dynamic setting when reindexing (#119441)
* [Upgrade Assistant] Remove duped copy from header (#119476)
sabarasaba added a commit that referenced this pull request Nov 24, 2021
…move duped copy from header (#119570)

* [Upgrade Assistant] Remove index_mapper_dynamic setting when reindexing (#119441)

* Add index_mapper_dynamic to removeList

* commit using @elastic.co

* [Upgrade Assistant] Remove duped copy from header (#119476)

* Remove duped copy from header

* commit using @elastic.co

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
…emove duped copy from header (#119569)

* [Upgrade Assistant] Remove index_mapper_dynamic setting when reindexing (#119441)
* [Upgrade Assistant] Remove duped copy from header (#119476)
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
…emove duped copy from header (elastic#119569)

* [Upgrade Assistant] Remove index_mapper_dynamic setting when reindexing (elastic#119441)
* [Upgrade Assistant] Remove duped copy from header (elastic#119476)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.16.1 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants