fix(NA): wrongly added include key on tsconfig.json for @kbn/monaco#118210
Merged
mistic merged 2 commits intoelastic:mainfrom Nov 11, 2021
Merged
fix(NA): wrongly added include key on tsconfig.json for @kbn/monaco#118210mistic merged 2 commits intoelastic:mainfrom
mistic merged 2 commits intoelastic:mainfrom
Conversation
mistic
added
chore
release_note:skip
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Nov 10, 2021
cjcenizal
approved these changes
Nov 10, 2021
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Code LGTM. Didn't test locally.
Contributor
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the layout of
@kbn/monacoso we can have the build working onWindowsthat is broken since #109233