[Getting Started Page] Add a space instead of an #11767
Merged
ycombinator merged 1 commit intoelastic:masterfrom May 12, 2017
Merged
[Getting Started Page] Add a space instead of an #11767ycombinator merged 1 commit intoelastic:masterfrom
ycombinator merged 1 commit intoelastic:masterfrom
Conversation
That way, a single block-level element before the space does not cause a new line in the UI
ycombinator
added
:Management
bug
rhoboat
approved these changes
May 12, 2017
rhoboat
left a comment
rhoboat
left a comment
There was a problem hiding this comment.
LGTM. phew that takes care of my quota for the day
ycombinator
added a commit
that referenced
this pull request
May 12, 2017
That way, a single block-level element before the space does not cause a new line in the UI
Contributor
Author
|
Backported to:
|
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
That way, a single block-level element before the space does not cause a new line in the UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #11673.
The Getting Started page has two pluggable sections. Users may register multiple strings (markup) into each of these two sections. Currently, we append an
to the end of each string. If the string contains a block-level element, this causes a new line in the UI, which is undesirable.This PR fixes this problem by using a regular space instead of the
.