[Security Solution][RAC] Fixes Threshold Rule functionality for post-rule-migration 8.0#117571
Merged
madirey merged 13 commits intoelastic:mainfrom Nov 9, 2021
Merged
[Security Solution][RAC] Fixes Threshold Rule functionality for post-rule-migration 8.0#117571madirey merged 13 commits intoelastic:mainfrom
madirey merged 13 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
marshallmain
approved these changes
Nov 9, 2021
Contributor
marshallmain
left a comment
There was a problem hiding this comment.
Code changes LGTM! Can you add a couple more sentences to the PR to add some details about what's being fixed here and how it behaves before and after the fix?
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 9, 2021
* Remove unused code * Fix threshold field refs * Fix import * UI fixes for Rules * Threshold Cypress test fixes * Type fixes * Threshold signal test fixes * Handle legacy schema optionally * Fix threshold integration test * More test fixes
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Contributor
Author
|
Thanks @marshallmain ... done! |
20 tasks
kibanamachine
added a commit
that referenced
this pull request
Nov 9, 2021
* Remove unused code * Fix threshold field refs * Fix import * UI fixes for Rules * Threshold Cypress test fixes * Type fixes * Threshold signal test fixes * Handle legacy schema optionally * Fix threshold integration test * More test fixes Co-authored-by: Madison Caldwell <madison.rey.caldwell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Threshold rules were broken after merging #112113 because the UI was referencing the
signal.*fields, whereas new alerts are generated using the AAD schema. Additionally, threshold alerts were being generated incorrectly, placingthreshold.resultat the top level of the document instead of underkibana.alert.threshold_resultwhere it belongs.This PR:
kibana.alert.threshold_result)nonEcsData,getFilterAndRuleBounds)signal.*fieldsChecklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers