Skip to content

[5.x] [UI Framework] Wrap Cards within a non-united CardGroup. (#11704) #11749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjcenizal merged 1 commit into from
May 11, 2017
Merged

[5.x] [UI Framework] Wrap Cards within a non-united CardGroup. (#11704) #11749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions ui_framework/components/card/_card_group.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,36 @@
/**
* 1. Use this container to offset the spacing between wrapped cards.
*/
.kuiCardGroupContainer {
margin: -$cardSpacing; /* 1 */
}

/**
* 1. Wrap cards when necessary.
*/
.kuiCardGroup {
display: flex;
flex-wrap: wrap; /* 1 */
}

/**
* 1. Use the defined width of the card to determine when to wrap.
* 2. Use an even margin all around the card so that the spacing is still even when wrapped.
*/
.kuiCardGroup__card {
flex: 1 1 0%;

& + & {
margin-left: 30px;
}
flex: 1 1 auto; /* 1 */
margin: $cardSpacing; /* 2 */
}

.kuiCardGroup__cardDescription {
flex: 1 1 auto;
}

/**
* 1. There's no way to make this look good when wrapped.
*/
.kuiCardGroup--united {
flex-wrap: nowrap; /* 1 */
border: 1px solid $cardBorderColor;
border-radius: $globalBorderRadius;
overflow: hidden;
Expand All @@ -25,7 +41,7 @@
}

.kuiCardGroup__card + .kuiCardGroup__card {
margin-left: 0;
margin: 0;
border-left: 1px solid $cardBorderColor;
}
}
1 change: 1 addition & 0 deletions ui_framework/components/card/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
$cardSpacing: 15px;
$cardBorderColor: #E0E0E0;
$cardMaxWidth: calc(100% - 48px);

Expand Down
40 changes: 33 additions & 7 deletions ui_framework/dist/ui_framework.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,35 +509,61 @@ body {
font-size: 14px;
padding: 0 15px 20px; }

/**
* 1. Use this container to offset the spacing between wrapped cards.
*/
.kuiCardGroupContainer {
margin: -15px;
/* 1 */ }

/**
* 1. Wrap cards when necessary.
*/
.kuiCardGroup {
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex; }
display: flex;
-webkit-flex-wrap: wrap;
-ms-flex-wrap: wrap;
flex-wrap: wrap;
/* 1 */ }

/**
* 1. Use the defined width of the card to determine when to wrap.
* 2. Use an even margin all around the card so that the spacing is still even when wrapped.
*/
.kuiCardGroup__card {
-webkit-box-flex: 1;
-webkit-flex: 1 1 0%;
-ms-flex: 1 1 0%;
flex: 1 1 0%; }
.kuiCardGroup__card + .kuiCardGroup__card {
margin-left: 30px; }
-webkit-flex: 1 1 auto;
-ms-flex: 1 1 auto;
flex: 1 1 auto;
/* 1 */
margin: 15px;
/* 2 */ }

.kuiCardGroup__cardDescription {
-webkit-box-flex: 1;
-webkit-flex: 1 1 auto;
-ms-flex: 1 1 auto;
flex: 1 1 auto; }

/**
* 1. There's no way to make this look good when wrapped.
*/
.kuiCardGroup--united {
-webkit-flex-wrap: nowrap;
-ms-flex-wrap: nowrap;
flex-wrap: nowrap;
/* 1 */
border: 1px solid #E0E0E0;
border-radius: 4px;
overflow: hidden; }
.kuiCardGroup--united .kuiCardGroup__card {
border: none;
border-radius: 0; }
.kuiCardGroup--united .kuiCardGroup__card + .kuiCardGroup__card {
margin-left: 0;
margin: 0;
border-left: 1px solid #E0E0E0; }

.kuiCollapseButton {
Expand Down
60 changes: 31 additions & 29 deletions ui_framework/doc_site/src/views/card/card_group.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,42 +1,44 @@
<div class="kuiCardGroup">
<div class="kuiCard kuiCardGroup__card">
<div class="kuiCard__description kuiCardGroup__cardDescription">
<div class="kuiCard__descriptionTitle">
Get a banana
<div class="kuiCardGroupContainer">
<div class="kuiCardGroup">
<div class="kuiCard kuiCardGroup__card">
<div class="kuiCard__description kuiCardGroup__cardDescription">
<div class="kuiCard__descriptionTitle">
Get a banana
</div>

<div class="kuiCard__descriptionText">
Bananas are yellow, fit easily in the hand, and have a lot of potassium or something.
</div>
</div>

<div class="kuiCard__descriptionText">
Bananas are yellow, fit easily in the hand, and have a lot of potassium or something.
<div class="kuiCard__footer">
<a class="kuiButton kuiButton--basic" href="#">
Banana!
</a>
</div>
</div>

<div class="kuiCard__footer">
<a class="kuiButton kuiButton--basic" href="#">
Banana!
</a>
</div>
</div>
<div class="kuiCard kuiCardGroup__card">
<div class="kuiCard__description kuiCardGroup__cardDescription">
<div class="kuiCard__descriptionTitle">
Get a pteradactyl
</div>

<div class="kuiCard kuiCardGroup__card">
<div class="kuiCard__description kuiCardGroup__cardDescription">
<div class="kuiCard__descriptionTitle">
Get a pteradactyl
<div class="kuiCard__descriptionText">
Pteradactyls can fly, like to squawk all the time, and are difficult to spell correctly.
</div>
</div>

<div class="kuiCard__descriptionText">
Pteradactyls can fly, like to squawk all the time, and are difficult to spell correctly.
<div class="kuiCard__footer">
<a
class="kuiButton kuiButton--primary"
href="https://www.elastic.co/subscriptions/xpack"
target="_blank"
>
Pteradactyl!
</a>
</div>
</div>

<div class="kuiCard__footer">
<a
class="kuiButton kuiButton--primary"
href="https://www.elastic.co/subscriptions/xpack"
target="_blank"
>
Pteradactyl!
</a>
</div>
</div>
</div>

Expand Down