[UI Framework] Wrap Cards within a non-united CardGroup.#11704
Merged
cjcenizal merged 2 commits intoelastic:masterfrom May 11, 2017
Merged
[UI Framework] Wrap Cards within a non-united CardGroup.#11704cjcenizal merged 2 commits intoelastic:masterfrom
cjcenizal merged 2 commits intoelastic:masterfrom
Conversation
cjcenizal
added
Team:Platform-Design
Contributor
Author
|
@ycombinator This can be used in the Getting Started page. Could you take a look and let me know if the markup makes sense to you? |
Contributor
|
Tested this PR with #11673 and the fix works as expected:
Reviewing code now... |
ycombinator
approved these changes
May 11, 2017
Contributor
ycombinator
left a comment
ycombinator
left a comment
There was a problem hiding this comment.
LGTM!
Nice to have but not necessary: It would be nice to show in the UI Framework an example of two (non-united) cards side-by-side that stack on top of each other when the window width is reduced.
|
|
||
| /** | ||
| * 1. Use the defined width of the card to determine when to wrap. | ||
| * 2. Use an event margin all around the card so that the spacing is still even when wrapped. |
Contributor
There was a problem hiding this comment.
Typo: Use an even margin all...
Contributor
Author
|
@ycombinator Thanks man, FYI the example you suggested already exists under the Card example:
|
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
May 11, 2017
* Wrap Cards within a non-united CardGroup.
cjcenizal
added a commit
that referenced
this pull request
May 11, 2017
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
* Wrap Cards within a non-united CardGroup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #11678