Skip to content

Revert "[Canvas] By-Value Embeddables (#113827)"#116504

Closed
brianseeders wants to merge 2 commits intoelastic:masterfrom
brianseeders:test-pr-revert
Closed

Revert "[Canvas] By-Value Embeddables (#113827)"#116504
brianseeders wants to merge 2 commits intoelastic:masterfrom
brianseeders:test-pr-revert

Conversation

@brianseeders
Copy link
Copy Markdown
Contributor

No description provided.

@brianseeders brianseeders added Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes v8.0.0 Team:Operations Kibana-Operations Team labels Oct 27, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] OSS CI Group #2 / bfetch explorer batchedFunction executes all requests in a batch

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1082 1070 -12
dashboard 305 219 -86
presentationUtil 330 124 -206
total -304

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dashboard 140 134 -6
presentationUtil 243 151 -92
total -98

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
presentationUtil 4 3 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB -33.0KB
dashboard 289.5KB 143.3KB -146.2KB
presentationUtil 234.4KB 43.1KB -191.2KB
total -370.4KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
dashboard 12 10 -2
presentationUtil 12 6 -6
total -8

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff errors
canvas 17.6KB 17.3KB -275.0B
dashboard 65.5KB 168.4KB +102.9KB ❌ 88.3KB over limit
presentationUtil 68.0KB 43.4KB -24.6KB
total +78.1KB

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
dashboard 20 17 -3
Unknown metric groups

API count

id before after diff
dashboard 153 147 -6
presentationUtil 271 178 -93
total -99

async chunk count

id before after diff
dashboard 3 1 -2
presentationUtil 9 6 -3
total -5

References to deprecated APIs

id before after diff
canvas 70 67 -3
presentationUtil 2 74 +72
total +69

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Oct 27, 2021

This does seem to help with CI execution time a lot, but includes two PRs and breaks dashboard bundle limits so I'm going to pursue this in #116527 instead.

@spalger spalger closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants