Skip to content

[Security Solutions] Improve deep links generation by capabilities#116274

Merged
semd merged 2 commits intoelastic:masterfrom
semd:109158-improve-deep-links-generation
Oct 26, 2021
Merged

[Security Solutions] Improve deep links generation by capabilities#116274
semd merged 2 commits intoelastic:masterfrom
semd:109158-improve-deep-links-generation

Conversation

@semd
Copy link
Copy Markdown
Contributor

@semd semd commented Oct 26, 2021

Summary

Follow up of: #113573

Improve the generation of deep links based on features enabled for the user, premium license restricted links, and experimental flags.

  • Implementation simplified for further changes.
  • Solved buggy behavior when a deep link has children deep links with different capabilities features.

Checklist

Delete any items that are not applicable to this PR.

@semd semd added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Cases labels Oct 26, 2021
@semd semd requested a review from XavierM October 26, 2021 11:51
@semd semd self-assigned this Oct 26, 2021
@semd semd requested a review from a team as a code owner October 26, 2021 11:51
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-threat-hunting-cases (Team:Threat Hunting:Cases)

Copy link
Copy Markdown
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what we talked about, that's a nice enhancement!!!

@semd semd enabled auto-merge (squash) October 26, 2021 16:31
@semd semd merged commit 109e0e7 into elastic:master Oct 26, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.5MB 4.5MB -239.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 253.1KB 253.2KB +90.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 28, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116274 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116274 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116274 or prevent reminders by adding the backport:skip label.

@spalger spalger added the backport:skip This PR does not require backporting label Nov 1, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants