Improve Discover screen-reader accessibility: #11598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Apply aria-label to field name icons. - Change title to alt for Discover 'Back to top' link. - Remove unnecessary title attributes from Discover No Results state. - Add aria-label to Discover sidebar's string field value. - Adjust aria-label of Discover Field Chooser 'Show field settings' button.
cjcenizal
commented
May 4, 2017
| class="kuiButton kuiButton--small pull-right discover-field-filter-toggle" | ||
| ng-click="showFilter = !showFilter" | ||
| aria-label="Field Settings" | ||
| aria-label="Show field settings" |
Contributor
Author
There was a problem hiding this comment.
I think we should use verbs to communicate to the screen reader what clicking this button will do.
cjcenizal
commented
May 4, 2017
| ng-click="onAddFilter(field, bucket.value, '-')" data-test-subj="minus-{{::field.name}}-{{::bucket.display}}"></i> | ||
| <i aria-hidden="true" class="fa fa-search-plus pull-right discover-field-details-filter" | ||
| ng-click="onAddFilter(field, bucket.value, '+')" data-test-subj="plus-{{::field.name}}-{{::bucket.display}}"></i> | ||
| <span aria-hidden="true" class="fa fa-search-minus pull-right discover-field-details-filter" |
Contributor
Author
There was a problem hiding this comment.
Not an accessibility thing, but we should never use <i> tags.
cjcenizal
commented
May 4, 2017
| css-truncate | ||
| css-truncate-expandable="true" | ||
| class="discover-field-details-value" | ||
| aria-label="Value: {{:: bucket.display === '' ? 'Empty string' : bucket.display }}" |
Contributor
Author
There was a problem hiding this comment.
No changes here, just formatting.
cjcenizal
commented
May 4, 2017
| </center> | ||
| These are the first {{opts.sampleSize}} documents matching | ||
| your search, refine your search to see others. | ||
| <a ng-click="toTop()">Back to top.</a> |
Contributor
Author
There was a problem hiding this comment.
Not accessibility related, just removed the <center> tag and changed the CSS to center this instead.
cjcenizal
commented
May 4, 2017
| ng-if="failures.length === failuresShown && failures.length > 5" | ||
| > | ||
| Show Less | ||
| </a> |
Contributor
Author
There was a problem hiding this comment.
Removed unnecessary title attributes here.
cjcenizal
added
Team:Platform-Design
Contributor
Author
|
jenkins, test this |
lukasolson
approved these changes
May 5, 2017
| string: stringFieldNameIcon, | ||
| }; | ||
|
|
||
| const typeIcon = function (fieldType) { |
Contributor
|
I'm definitely not an accessibility expert so I can't judge how well this adheres to best practices, but I did use OSX VoiceOver to confirm that all of the updated elements in this PR are accessible via screen reader. LGTM. |
Bargs
approved these changes
May 9, 2017
cjcenizal
deleted the
11520/improvement/discover-screen-reader-accessibility
branch
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
May 9, 2017
- Apply aria-label to field name icons. - Change title to alt for Discover 'Back to top' link. - Remove unnecessary title attributes from Discover No Results state. - Add aria-label to Discover sidebar's string field value. - Adjust aria-label of Discover Field Chooser 'Show field settings' button.
cjcenizal
added a commit
that referenced
this pull request
May 9, 2017
- Apply aria-label to field name icons. - Change title to alt for Discover 'Back to top' link. - Remove unnecessary title attributes from Discover No Results state. - Add aria-label to Discover sidebar's string field value. - Adjust aria-label of Discover Field Chooser 'Show field settings' button.
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
- Apply aria-label to field name icons. - Change title to alt for Discover 'Back to top' link. - Remove unnecessary title attributes from Discover No Results state. - Add aria-label to Discover sidebar's string field value. - Adjust aria-label of Discover Field Chooser 'Show field settings' button.
snide
pushed a commit
to snide/kibana
that referenced
this pull request
Jun 2, 2017
- Apply aria-label to field name icons. - Change title to alt for Discover 'Back to top' link. - Remove unnecessary title attributes from Discover No Results state. - Add aria-label to Discover sidebar's string field value. - Adjust aria-label of Discover Field Chooser 'Show field settings' button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #11520. Extracts some work from #11548.