[Uptime] Uptime index config using kibana.yml by shahzad31 · Pull Request #115775 · elastic/kibana

shahzad31 · 2021-10-20T14:05:39Z

Summary

Fix #115774

Now you can config uptime index settings using kibana.yml key

xpack.uptime.index: remote_cluster:heartbeat-*

This will allow robots team to config ccs with new olbt-cli setup

Testing

set the key for above config and check that when uptime settings page loads,

it show that key

but when user override it, saved objects uptime settings should take precedence

elasticmachine · 2021-10-20T14:05:44Z

Pinging @elastic/uptime (Team:uptime)

jbudz

kibana-docker LGTM

kibanamachine · 2021-10-20T19:07:43Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💔 Build #163283 failed 0c5154d
💔 Build #163293 failed 4f66560

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

justinkambic

I encountered an error after setting this. Is there some additional configuration I need to do in order to get this working?

Saw error logs like this in Kibana server log:

[2021-10-20T16:37:30.230-04:00][ERROR][http] ResponseError: security_exception: [no_such_remote_cluster_exception] Reason: no such remote cluster: [remote_cluster]

shahzad31 · 2021-10-21T11:17:34Z

I encountered an error after setting this. Is there some additional configuration I need to do in order to get this working?

Saw error logs like this in Kibana server log:
[2021-10-20T16:37:30.230-04:00][ERROR][http] ResponseError: security_exception: [no_such_remote_cluster_exception] Reason: no such remote cluster: [remote_cluster]

@justinkambic no, it should just work, what key you were using?

shahzad31 · 2021-10-25T16:58:12Z

@elasticmachine merge upstream

justinkambic · 2021-10-25T20:18:58Z

@shahzad31 still seeing that error, my only config entry is:

xpack.uptime.index: remote_cluster:heartbeat-*

We can pair if you want to see, not sure how to debug.

shahzad31 · 2021-10-25T20:24:11Z

@shahzad31 still seeing that error, my only config entry is:
xpack.uptime.index: remote_cluster:heartbeat-*
We can pair if you want to see, not sure how to debug.

I actually had remote_cluster: configured using olbt-cli, in your case, you just need to add your heartbeat index pattern like heartbeat-*

shahzad31 · 2021-10-26T14:09:18Z

@elasticmachine merge upstream

justinkambic · 2021-10-26T14:10:15Z

Ok, this works in that case. We may want to create a follow-up to improve error handling where CCS is not configured. Lots of nasty error messages show up in the Kibana log for unrelated components of the app.

justinkambic

LGTM. One nit comment.

justinkambic · 2021-10-26T14:43:52Z

x-pack/plugins/uptime/server/plugin.ts

  }

  public setup(core: CoreSetup, plugins: UptimeCorePlugins) {
+    const config = this.initContext.config.get<UptimeConfig>();


We can probably skip this declaration, since we're only using the symbol one time right below here.

kibanamachine · 2021-10-26T18:28:01Z

💛 Build succeeded, but was flaky

Metrics [docs]

✅ unchanged

History

💔 Build #1494 failed 28426bc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-10-27T08:15:53Z

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 115775

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-10-27T08:26:01Z

💚 Backport successful

Status	Branch	Result
✅	7.16

This backport PR will be merged automatically after passing CI.

…-migrate-away-from-injected-css-js * 'master' of github.com:elastic/kibana: (61 commits) [ML] Nodes overview for the Model Management page (elastic#116361) [Uptime] Uptime index config using kibana.yml (elastic#115775) [Controls] Dashboard Integration (elastic#115991) skip flaky suite (elastic#104260) Include Files in GitHub UI (elastic#115956) skip flaky suite (elastic#116060) [Canvas] By-Value Embeddables (elastic#113827) Skip failing test (elastic#115366) [Osquery] Fix live query search doesn't return relevant results for agents (elastic#116332) [Integrations] Added link in old Add Data description and fixed alignment in cards (elastic#116213) [Actions] Extended ActionTypeRegistry with connector validation to validate config with secrets (elastic#116079) skip flaky suite (elastic#109329) Grant access to machine learning features when base privileges are used (elastic#115444) Skipping failing test (elastic#84957) [RAC][Security Solution] Adds migration to new SecuritySolution rule types (elastic#112113) skip flaky suite (elastic#115366) [Fleet] Marking API spec as experimental (elastic#116331) [Docs] Cleaning up the versions in the upgrade paths. Closes elastic#116223 (elastic#116228) [Reporting] Suppress debug logs in the mock logger (elastic#116012) [Metrics UI] Clear threshold alert groups state when filterQuery changes (elastic#116205) ... # Conflicts: # src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx # src/plugins/dashboard/public/types.ts

kibanamachine · 2021-10-28T08:23:22Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115775 or prevent reminders by adding the backport:skip label.

Uptime index config using kibana.yml

0c5154d

shahzad31 requested review from a team as code owners October 20, 2021 14:05

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 20, 2021

shahzad31 added release_note:enhancement v8.0.0 labels Oct 20, 2021

fix schema

4f66560

jbudz approved these changes Oct 20, 2021

View reviewed changes

shahzad31 added 2 commits October 20, 2021 18:21

fix typing

211dacf

use simple appraoch

b353322

justinkambic reviewed Oct 20, 2021

View reviewed changes

Merge branch 'master' into uptime-index-config

28426bc

Merge branch 'master' into uptime-index-config

6b78f89

justinkambic approved these changes Oct 26, 2021

View reviewed changes

justinkambic mentioned this pull request Oct 26, 2021

[Uptime] Improve error handling when CCS is not enabled elastic/uptime#394

Open

shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 27, 2021

shahzad31 merged commit 98231f4 into elastic:master Oct 27, 2021

shahzad31 deleted the uptime-index-config branch October 27, 2021 08:15

shahzad31 added v7.16.0 and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Oct 27, 2021

shahzad31 added auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 27, 2021

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 27, 2021

[Uptime] Uptime index config using kibana.yml (elastic#115775)

92cafad

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine mentioned this pull request Oct 27, 2021

[Uptime] Uptime index config using kibana.yml (#115775) #116406

Closed

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 28, 2021

shahzad31 added the backport:skip This PR does not require backporting label Oct 28, 2021

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 28, 2021

Conversation

shahzad31 commented Oct 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

elasticmachine commented Oct 20, 2021

Uh oh!

jbudz left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Oct 20, 2021

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

shahzad31 commented Oct 21, 2021

Uh oh!

shahzad31 commented Oct 25, 2021

Uh oh!

justinkambic commented Oct 25, 2021

Uh oh!

shahzad31 commented Oct 25, 2021

Uh oh!

shahzad31 commented Oct 26, 2021

Uh oh!

justinkambic commented Oct 26, 2021

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Oct 26, 2021

💛 Build succeeded, but was flaky

Metrics [docs]

History

Uh oh!

kibanamachine commented Oct 27, 2021

💔 Backport failed

Uh oh!

kibanamachine commented Oct 27, 2021

💚 Backport successful

Uh oh!

kibanamachine commented Oct 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shahzad31 commented Oct 20, 2021 •

edited

Loading