Upgrade EUI to v40.0.0 by thompsongl · Pull Request #115639 · elastic/kibana

thompsongl · 2021-10-19T19:28:09Z

Summary

eui@39.1.1 ⏩ eui@40.0.0

Breaking change not relevant to Kibana

`40.0.0`

Updated tokenKeyword to match the definition of keyword field type (#5251)
Added element, buttonElement, and arrowProps props to further customize EuiAccordion (#5258)
Fixed missing id for EuiCombobox by generating one if prepend or append exists (#5229)

Breaking changes

Renamed tokenKeyword icon to tokenTag in EuiToken (#5251)

kibanamachine · 2021-10-20T17:50:21Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`core`	132.4KB	132.4KB	+1.0B
`dataVisualizer`	533.0KB	533.0KB	-4.0B
`enterpriseSearch`	1.4MB	1.4MB	-32.0B
`fleet`	619.6KB	619.6KB	+1.0B
`kibanaReact`	217.3KB	217.3KB	+1.0B
`kibanaUtils`	52.1KB	52.1KB	+1.0B
`security`	507.8KB	507.8KB	+1.0B
`securitySolution`	4.6MB	4.6MB	+1.0B
total			-30.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-css`	597.0KB	596.8KB	-251.0B
`kbnUiSharedDeps-npmDll`	5.0MB	5.0MB	+348.0B
total			+97.0B

History

💔 Build #162919 failed 0e5eae6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thompsongl · 2021-10-20T17:54:12Z

...se_search/public/applications/app_search/components/curations/components/curations_table.tsx

-        // @ts-ignore
        enlarge: true,
        width: '100%',
-        truncateText: false,


Per https://elastic.github.io/eui/#/tabular-content/tables#responsive-tables truncateText has no effect without a custom render

Haha, I remember adding this comment. I wish I could approve the change now

Although, question, shouldn't the non-mobile truncateText on line 73 up above also get removed? Or am I not understanding what you're saying?

truncateText on L73 is valid. It's just not valid in the mobileOptions config.

Gotcha, thanks!

thompsongl · 2021-10-20T17:54:19Z

...earch/public/applications/app_search/components/engines/components/tables/shared_columns.tsx

-    // @ts-ignore
    enlarge: true,
    width: '100%',
-    truncateText: false,


Per https://elastic.github.io/eui/#/tabular-content/tables#responsive-tables truncateText has no effect without a custom render

elasticmachine · 2021-10-20T17:54:34Z

Pinging @elastic/eui-design (EUI)

elasticmachine · 2021-10-20T17:58:11Z

Pinging @elastic/uptime (Team:uptime)

This reverts commit 0e5eae6.

nreese

maps changes LGTM

spong

Security Solution changes LGTM! Just a few snapshot updates -- we're over the hill now, thanks @thompsongl! 🙂

estermv

Stack Monitoring changes LGTM

justinkambic

Uptime changes LGTM.

qn895 · 2021-10-21T16:13:25Z

ML changes LGTM 🎉

thompsongl · 2021-10-25T14:36:29Z

@elastic/app-search-frontend review is for non-snapshot code.

@elastic/kibana-app-services, @elastic/kibana-presentation, @elastic/kibana-reporting-services, @elastic/kibana-vis-editors reviews are for snapshot changes only.

I will plan to merge EOD to allow time before FF

flash1293

VisEditors changes LGTM, simple snapshot updates, code review only

kibanamachine · 2021-10-25T16:41:48Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`core`	132.4KB	132.4KB	+1.0B
`enterpriseSearch`	1.4MB	1.4MB	-32.0B
`fleet`	621.3KB	621.3KB	+1.0B
`kibanaReact`	217.3KB	217.3KB	+1.0B
`kibanaUtils`	52.1KB	52.1KB	+1.0B
`security`	507.8KB	507.8KB	+1.0B
`securitySolution`	4.6MB	4.6MB	+1.0B
total			-26.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-css`	597.0KB	596.8KB	-251.0B
`kbnUiSharedDeps-npmDll`	5.0MB	5.0MB	+348.0B
total			+97.0B

History

💚 Build #752 succeeded aa1dc43
💔 Build #706 failed cea19fe
💛 Build #612 was flaky e2d9d75

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-10-27T17:03:22Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115639 or prevent reminders by adding the backport:skip label.

kibanamachine · 2021-10-28T17:13:23Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115639 or prevent reminders by adding the backport:skip label.

kibanamachine · 2021-10-29T17:23:25Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115639 or prevent reminders by adding the backport:skip label.

kibanamachine · 2021-11-01T17:29:50Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115639 or prevent reminders by adding the backport:skip label.

thompsongl added 2 commits October 19, 2021 14:15

eui to v40.0.0

56aeb1f

tokenKeyword -> tokenTag

0e5eae6

thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI labels Oct 19, 2021

thompsongl changed the title ~~Upgrae EUI to v40.0.0~~ Upgrade EUI to v40.0.0 Oct 19, 2021

thompsongl added 3 commits October 19, 2021 16:16

mobileOptions type

28e9e80

snapshot updates

5096bf2

Merge branch 'master' into eui/40

3345137

Merge branch 'master' into eui/40

e2d9d75

thompsongl commented Oct 20, 2021

View reviewed changes

thompsongl marked this pull request as ready for review October 20, 2021 17:54

thompsongl requested a review from a team October 20, 2021 17:54

thompsongl requested review from a team as code owners October 20, 2021 17:54

thompsongl requested a review from a team October 20, 2021 17:54

thompsongl requested review from a team as code owners October 20, 2021 17:54

thompsongl requested a review from a team October 20, 2021 17:54

thompsongl requested a review from a team as a code owner October 20, 2021 17:54

lukeelmers approved these changes Oct 20, 2021

View reviewed changes

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 20, 2021

jbudz approved these changes Oct 20, 2021

View reviewed changes

Revert "tokenKeyword -> tokenTag"

b8ff64e

This reverts commit 0e5eae6.

nreese approved these changes Oct 20, 2021

View reviewed changes

spong approved these changes Oct 20, 2021

View reviewed changes

thompsongl added 3 commits October 20, 2021 16:03

Merge branch 'master' into eui/40

cea19fe

token snapshot

9f3d8d5

Merge branch 'master' into eui/40

aa1dc43

estermv approved these changes Oct 21, 2021

View reviewed changes

justinkambic approved these changes Oct 21, 2021

View reviewed changes

qn895 approved these changes Oct 21, 2021

View reviewed changes

Merge branch 'master' into eui/40

a8b161b

flash1293 approved these changes Oct 25, 2021

View reviewed changes

JasonStoltz approved these changes Oct 25, 2021

View reviewed changes

thompsongl merged commit 59815a0 into elastic:master Oct 25, 2021

dgieselaar mentioned this pull request Oct 27, 2021

[APM] Trace waterfall is visually broken #116393

Closed

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 27, 2021

thompsongl added the backport:skip This PR does not require backporting label Nov 1, 2021

spalger added backport:skip This PR does not require backporting and removed backport:skip This PR does not require backporting labels Nov 1, 2021

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 1, 2021

Conversation

thompsongl commented Oct 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

40.0.0

Uh oh!

kibanamachine commented Oct 20, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

thompsongl Oct 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cee-chen Oct 20, 2021

Choose a reason for hiding this comment

Uh oh!

cee-chen Oct 20, 2021

Choose a reason for hiding this comment

Uh oh!

thompsongl Oct 20, 2021

Choose a reason for hiding this comment

Uh oh!

cee-chen Oct 20, 2021

Choose a reason for hiding this comment

Uh oh!

thompsongl Oct 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Oct 20, 2021

Uh oh!

elasticmachine commented Oct 20, 2021

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

spong left a comment

Choose a reason for hiding this comment

Uh oh!

estermv left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

qn895 commented Oct 21, 2021

Uh oh!

thompsongl commented Oct 25, 2021

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Oct 25, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

kibanamachine commented Oct 27, 2021

Uh oh!

kibanamachine commented Oct 28, 2021

Uh oh!

kibanamachine commented Oct 29, 2021

Uh oh!

kibanamachine commented Nov 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

thompsongl commented Oct 19, 2021 •

edited

Loading

`40.0.0`

thompsongl Oct 20, 2021 •

edited

Loading

thompsongl Oct 20, 2021 •

edited

Loading