Skip to content

[7.x] [ML] Adding ability to change data view in advanced job wizard (#115191)#115585

Merged
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-115191
Oct 19, 2021
Merged

[7.x] [ML] Adding ability to change data view in advanced job wizard (#115191)#115585
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-115191

Conversation

@kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

…ic#115191)

* [ML] Adding ability to change data view in advanced job wizard

* updating translation ids

* type and text changes

* code clean up

* route id change

* text changes

* text change

* changing data view to index pattern

* adding api tests

* text updates

* removing first step

* renaming temp variable

* adding permission checks

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Oct 19, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) October 19, 2021 14:54
@kibanamachine
Copy link
Contributor Author

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/jobs/categorization_field_examples·ts.apis Machine Learning jobs Categorization example endpoint - valid with good number of tokens

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]     │
[00:00:00]       └-: apis
[00:00:00]         └-> "before all" hook in "apis"
[00:09:35]         └-: Machine Learning
[00:09:35]           └-> "before all" hook in "Machine Learning"
[00:09:35]           └-> "before all" hook in "Machine Learning"
[00:09:35]             │ debg creating role ft_ml_source
[00:09:35]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_source]
[00:09:35]             │ debg creating role ft_ml_source_readonly
[00:09:35]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_source_readonly]
[00:09:35]             │ debg creating role ft_ml_dest
[00:09:35]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_dest]
[00:09:35]             │ debg creating role ft_ml_dest_readonly
[00:09:35]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_dest_readonly]
[00:09:35]             │ debg creating role ft_ml_ui_extras
[00:09:35]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_ui_extras]
[00:09:35]             │ debg creating role ft_default_space_ml_all
[00:09:35]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_all]
[00:09:35]             │ debg creating role ft_default_space1_ml_all
[00:09:35]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space1_ml_all]
[00:09:35]             │ debg creating role ft_all_spaces_ml_all
[00:09:35]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_all_spaces_ml_all]
[00:09:35]             │ debg creating role ft_default_space_ml_read
[00:09:35]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_read]
[00:09:35]             │ debg creating role ft_default_space1_ml_read
[00:09:35]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space1_ml_read]
[00:09:35]             │ debg creating role ft_all_spaces_ml_read
[00:09:35]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_all_spaces_ml_read]
[00:09:35]             │ debg creating role ft_default_space_ml_none
[00:09:35]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_none]
[00:09:35]             │ debg creating user ft_ml_poweruser
[00:09:35]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser]
[00:09:35]             │ debg created user ft_ml_poweruser
[00:09:35]             │ debg creating user ft_ml_poweruser_spaces
[00:09:35]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_spaces]
[00:09:35]             │ debg created user ft_ml_poweruser_spaces
[00:09:35]             │ debg creating user ft_ml_poweruser_space1
[00:09:35]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_space1]
[00:09:35]             │ debg created user ft_ml_poweruser_space1
[00:09:35]             │ debg creating user ft_ml_poweruser_all_spaces
[00:09:35]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_all_spaces]
[00:09:35]             │ debg created user ft_ml_poweruser_all_spaces
[00:09:35]             │ debg creating user ft_ml_viewer
[00:09:36]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer]
[00:09:36]             │ debg created user ft_ml_viewer
[00:09:36]             │ debg creating user ft_ml_viewer_spaces
[00:09:36]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_spaces]
[00:09:36]             │ debg created user ft_ml_viewer_spaces
[00:09:36]             │ debg creating user ft_ml_viewer_space1
[00:09:36]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_space1]
[00:09:36]             │ debg created user ft_ml_viewer_space1
[00:09:36]             │ debg creating user ft_ml_viewer_all_spaces
[00:09:36]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_all_spaces]
[00:09:36]             │ debg created user ft_ml_viewer_all_spaces
[00:09:36]             │ debg creating user ft_ml_unauthorized
[00:09:36]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_unauthorized]
[00:09:36]             │ debg created user ft_ml_unauthorized
[00:09:36]             │ debg creating user ft_ml_unauthorized_spaces
[00:09:36]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_unauthorized_spaces]
[00:09:36]             │ debg created user ft_ml_unauthorized_spaces
[00:13:56]           └-: jobs
[00:13:56]             └-> "before all" hook in "jobs"
[00:13:56]             └-: Categorization example endpoint - 
[00:13:56]               └-> "before all" hook for "valid with good number of tokens"
[00:13:56]               └-> "before all" hook for "valid with good number of tokens"
[00:13:56]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Loading "mappings.json"
[00:13:56]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Loading "data.json.gz"
[00:13:56]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [ft_categorization] creating index, cause [api], templates [], shards [1]/[0]
[00:13:56]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Created index "ft_categorization"
[00:13:56]                 │ debg [x-pack/test/functional/es_archives/ml/categorization] "ft_categorization" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:13:57]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Indexed 1501 docs into "ft_categorization"
[00:13:57]                 │ debg applying update to kibana config: {"dateFormat:tz":"UTC"}
[00:13:57]               └-> valid with good number of tokens
[00:13:57]                 └-> "before each" hook: global before each for "valid with good number of tokens"
[00:13:57]                 └- ✖ fail: apis Machine Learning jobs Categorization example endpoint -  valid with good number of tokens
[00:13:57]                 │       Error: expected [ { id: 3,
[00:13:57]                 │     valid: 'valid',
[00:13:57]                 │     message: '1000 field values analyzed, 96% contain 3 or more tokens.' } ] to sort of equal [ { id: 3,
[00:13:57]                 │     valid: 'valid',
[00:13:57]                 │     message: '1000 field values analyzed, 95% contain 3 or more tokens.' } ]
[00:13:57]                 │       + expected - actual
[00:13:57]                 │ 
[00:13:57]                 │        [
[00:13:57]                 │          {
[00:13:57]                 │            "id": 3
[00:13:57]                 │       -    "message": "1000 field values analyzed, 96% contain 3 or more tokens."
[00:13:57]                 │       +    "message": "1000 field values analyzed, 95% contain 3 or more tokens."
[00:13:57]                 │            "valid": "valid"
[00:13:57]                 │          }
[00:13:57]                 │        ]
[00:13:57]                 │       
[00:13:57]                 │       at Assertion.assert (/dev/shm/workspace/parallel/20/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:13:57]                 │       at Assertion.eql (/dev/shm/workspace/parallel/20/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:13:57]                 │       at Context.<anonymous> (test/api_integration/apis/ml/jobs/categorization_field_examples.ts:304:42)
[00:13:57]                 │       at runMicrotasks (<anonymous>)
[00:13:57]                 │       at processTicksAndRejections (node:internal/process/task_queues:96:5)
[00:13:57]                 │       at Object.apply (/dev/shm/workspace/parallel/20/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:13:57]                 │ 
[00:13:57]                 │ 

Stack Trace

Error: expected [ { id: 3,
    valid: 'valid',
    message: '1000 field values analyzed, 96% contain 3 or more tokens.' } ] to sort of equal [ { id: 3,
    valid: 'valid',
    message: '1000 field values analyzed, 95% contain 3 or more tokens.' } ]
    at Assertion.assert (/dev/shm/workspace/parallel/20/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/20/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at Context.<anonymous> (test/api_integration/apis/ml/jobs/categorization_field_examples.ts:304:42)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (/dev/shm/workspace/parallel/20/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16) {
  actual: '[\n' +
    '  {\n' +
    '    "id": 3\n' +
    '    "message": "1000 field values analyzed, 96% contain 3 or more tokens."\n' +
    '    "valid": "valid"\n' +
    '  }\n' +
    ']',
  expected: '[\n' +
    '  {\n' +
    '    "id": 3\n' +
    '    "message": "1000 field values analyzed, 95% contain 3 or more tokens."\n' +
    '    "valid": "valid"\n' +
    '  }\n' +
    ']',
  showDiff: true
}

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1683 1687 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.6MB 3.6MB +6.4KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@kibanamachine kibanamachine merged commit 6e64940 into elastic:7.x Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments