Skip to content

[Dashboards] Fix potential error from undefined #115562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crob611 merged 1 commit into from
Oct 19, 2021
Merged

[Dashboards] Fix potential error from undefined #115562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/plugins/dashboard/public/saved_dashboards/saved_dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,14 +114,14 @@ export function createSavedDashboardClass(
},

// if this is null/undefined then the SavedObject will be assigned the defaults
id: typeof arg === 'string' ? arg : arg.id,
id: typeof arg === 'object' ? arg.id : arg,

// default values that will get assigned if the doc is new
defaults,
});

const id: string = typeof arg === 'string' ? arg : arg.id;
const useResolve = typeof arg === 'string' ? false : arg.useResolve;
const id: string = typeof arg === 'object' ? arg.id : arg;
const useResolve = typeof arg === 'object' ? arg.useResolve : false;

this.getFullPath = () => `/app/dashboards#${createDashboardEditUrl(this.aliasId || this.id)}`;

Expand Down