[ES client] Rename deprecated params#115528
Conversation
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/management/snapshot_restore/policies·ts.apis management Snapshot and Restore SLM policies Create should create a SLM policyStandard OutStack TraceKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/management/snapshot_restore/policies·ts.apis management Snapshot and Restore SLM policies Create "after all" hook for "should create a policy with only required fields"Standard OutStack TraceKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/management/snapshot_restore/policies·ts.apis management Snapshot and Restore SLM policies Create should create a SLM policyStandard OutStack Traceand 2 more failures, only showing the first 3. Metrics [docs]
To update your PR or re-run it, just comment with: |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
yctercero
left a comment
There was a problem hiding this comment.
Security solution changes LGTM.
patrykkopycinski
left a comment
There was a problem hiding this comment.
Asset Management LGTM
cjcenizal
left a comment
There was a problem hiding this comment.
Rubberstamping approval. @elastic/kibana-app-services You are the owners for the file that was touched: https://github.com/elastic/kibana/pull/115528/files#diff-97c352c28918de15081fb5ef9d9405e42c42fb4539e114d186f908d20bf49f58
mattkime
left a comment
There was a problem hiding this comment.
app services change lgtm
jloleysens
left a comment
There was a problem hiding this comment.
Reporting changes LGTM
* filterPath --> filter_path * ignoreUnavailable --> ignore_unavailable * ignoreUnavailable --> ignore_unavailable * trackScores --> track_scores * trackTotalHits --> track_total_hits * rollback unnecessary changes
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* filterPath --> filter_path * ignoreUnavailable --> ignore_unavailable * ignoreUnavailable --> ignore_unavailable * trackScores --> track_scores * trackTotalHits --> track_total_hits * rollback unnecessary changes Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Summary
Extracted from #113950
In the next major release
@elastic/elasticsearchclient dropscamelCasesupport for keys.Renames the next params:
I'm going to port the changes to
7.xto avoid merge conflicts during backports.Let me know if you find other usages in the plugin code.