[Connectors][ServiceNow] Default isLegacy to true for API consumers#115367
[Connectors][ServiceNow] Default isLegacy to true for API consumers#115367cnasikas merged 8 commits intoelastic:masterfrom
isLegacy to true for API consumers#115367Conversation
|
Pinging @elastic/security-threat-hunting-cases (Team:Threat Hunting:Cases) |
pmuellr
left a comment
There was a problem hiding this comment.
LGTM; however, I think we'll need to update the docs now, to indicate that the isLegacy flag should be set to false when creating new connectors. For example, docs/management/connectors/action-types/servicenow.asciidoc (though I'm not sure exactly which SN connectors need this). Can be done in a follow-up PR ...
|
Thanks, @pmuellr! I will do it in this PR. |
5e9e2ef to
76a6aa5
Compare
|
Doc changes LGTM, thx! |
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts.saved objects tagging - functional tests dashboard integration editing allows to select tags for an existing dashboardStandard OutStack TraceKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/jobs/categorization_field_examples·ts.apis Machine Learning jobs Categorization example endpoint - partially valid, more than 75% are nullStandard OutStack TraceMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
PR #105440 introduces a new
configattribute calledisLegacyto distinguish deprecated connectors and new ones. In this PR the default value was set tofalse. This is a breaking change as it could potentially break automated tools consuming the connector's API. For that reason, this PR changes the default value totrueand forces the UI to set theisLegacytofalsewhen creating new connectors.doc previews: