[Transform] Add alerting rules management to Transform UI by darnautov · Pull Request #115363 · elastic/kibana

darnautov · 2021-10-18T13:21:28Z

Summary

Closes #111945

Allows creating an alerting rule at the last step of the Transform wizard
Indicates if there are alerting rules associated with transform
Shows associated alerting rules in the expanded row and allows to edit it directly

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

elasticmachine · 2021-10-18T13:21:31Z

Pinging @elastic/ml-ui (:ml)

…update-wizard

...transform/public/app/sections/transform_management/components/transform_list/use_columns.tsx

...s/transform/public/app/sections/create_transform/components/step_create/step_create_form.tsx

szabosteve

UI text LGTM!

...s/transform/public/app/sections/create_transform/components/step_create/step_create_form.tsx

peteharverson

Tested and overall LGTM.

Just wonder if it would be possible to add Create alert rule to the Actions menu too?

peteharverson

Tested latest change adding a Create action to the actions menu in the management list and LGTM

darnautov · 2021-10-19T11:30:02Z

@elasticmachine merge upstream

walterra

Code LGTM

kibanamachine · 2021-10-19T15:08:15Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`transform`	235	241	+6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`transform`	322.3KB	327.5KB	+5.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`transform`	15.5KB	15.6KB	+49.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

…5363) * transform alert flyout * fetch alerting rules * show alerting rules indicators * filter continuous transforms * add alert rules to the expanded row * edit alert rule from the list * fix ts issues * fix types * update texts * refactor using context, wip create alert from the list * update unit test * fix ts issue * privilege check

kibanamachine · 2021-10-19T15:20:05Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (30 commits) Fix potential error from undefined (elastic#115562) [App Search, Crawler] Fix validation step panel padding/whitespace (elastic#115542) [Cases][Connectors] ServiceNow ITOM: MVP (elastic#114125) Change default session idle timeout to 8 hours. (elastic#115565) Upgrade EUI to v39.1.1 (elastic#114732) [App Search] Wired up organic results on Curation Suggestions view (elastic#114717) [i18n] remove i18n html extractor (elastic#115004) [Logs/Metrics UI] Add deprecated field configuration to Deprecations API (elastic#115103) [Transform] Add alerting rules management to Transform UI (elastic#115363) Update UI links to Fleet and Agent docs (elastic#115295) [ML] Adding ability to change data view in advanced job wizard (elastic#115191) Change deleteByNamespace to include legacy URL aliases (elastic#115459) [Unified Integrations] Remove and cleanup add data views (elastic#115424) [Discover] Show ignored field values (elastic#115040) [ML] Stop reading the ml.max_open_jobs node attribute (elastic#115524) [Discover] Improve doc viewer code in Discover (elastic#114759) [Security Solutions] Adds security detection rule actions as importable and exportable (elastic#115243) [Security Solution] [Platform] Migrate legacy actions whenever user interacts with the rule (elastic#115101) [Fleet] Add telemetry for integration cards (elastic#115413) 🐛 Fix single percentile case when ES is returning no buckets (elastic#115214) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap

…115589) * transform alert flyout * fetch alerting rules * show alerting rules indicators * filter continuous transforms * add alert rules to the expanded row * edit alert rule from the list * fix ts issues * fix types * update texts * refactor using context, wip create alert from the list * update unit test * fix ts issue * privilege check Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>

darnautov added 6 commits October 18, 2021 11:45

transform alert flyout

87aebde

fetch alerting rules

db6cf87

show alerting rules indicators

85daf71

filter continuous transforms

65e4a47

add alert rules to the expanded row

031d593

edit alert rule from the list

4ec8d70

darnautov added enhancement New value added to drive a business result :ml v8.0.0 Feature:Transforms Transforms auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 18, 2021

darnautov requested review from peteharverson and walterra October 18, 2021 13:21

darnautov self-assigned this Oct 18, 2021

darnautov requested a review from a team as a code owner October 18, 2021 13:21

darnautov added release_note:feature Makes this part of the condensed release notes and removed enhancement New value added to drive a business result labels Oct 18, 2021

Merge remote-tracking branch 'upstream/master' into transform-111945-…

75a7663

…update-wizard

darnautov requested a review from szabosteve October 18, 2021 13:31

fix ts issues

d08e6fd

darnautov mentioned this pull request Oct 18, 2021

[Transform] Alerting rule type for Transform health monitoring #111945

Closed

3 tasks

szabosteve reviewed Oct 18, 2021

View reviewed changes

darnautov added 2 commits October 18, 2021 17:34

fix types

b828a04

update texts

9fd0401

darnautov requested a review from a team as a code owner October 18, 2021 15:40

darnautov requested a review from szabosteve October 18, 2021 15:41

szabosteve approved these changes Oct 18, 2021

View reviewed changes

peteharverson reviewed Oct 18, 2021

View reviewed changes

...s/transform/public/app/sections/create_transform/components/step_create/step_create_form.tsx Show resolved Hide resolved

peteharverson reviewed Oct 18, 2021

View reviewed changes

darnautov added 2 commits October 19, 2021 11:13

refactor using context, wip create alert from the list

82cb90d

update unit test

c638194

peteharverson approved these changes Oct 19, 2021

View reviewed changes

fix ts issue

aa7c87c

kibanamachine and others added 2 commits October 19, 2021 07:30

Merge branch 'master' into transform-111945-update-wizard

df20d58

privilege check

9372b2a

walterra approved these changes Oct 19, 2021

View reviewed changes

darnautov merged commit 2aaa515 into elastic:master Oct 19, 2021

darnautov deleted the transform-111945-update-wizard branch October 19, 2021 15:15

kibanamachine mentioned this pull request Oct 19, 2021

[7.x] [Transform] Add alerting rules management to Transform UI (#115363) #115589

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Transform] Add alerting rules management to Transform UI#115363

[Transform] Add alerting rules management to Transform UI#115363
darnautov merged 15 commits intoelastic:masterfrom
darnautov:transform-111945-update-wizard

darnautov commented Oct 18, 2021 •

edited by peteharverson

Loading

Uh oh!

elasticmachine commented Oct 18, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

szabosteve left a comment

Uh oh!

Uh oh!

peteharverson left a comment

Uh oh!

peteharverson left a comment

Uh oh!

darnautov commented Oct 19, 2021

Uh oh!

walterra left a comment

Uh oh!

kibanamachine commented Oct 19, 2021

Uh oh!

kibanamachine commented Oct 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

darnautov commented Oct 18, 2021 • edited by peteharverson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Oct 18, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

szabosteve left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

darnautov commented Oct 19, 2021

Uh oh!

walterra left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Oct 19, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

kibanamachine commented Oct 19, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

darnautov commented Oct 18, 2021 •

edited by peteharverson

Loading