Skip to content

[7.x] Update Security/Cases deprecation message #115250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jportner merged 4 commits into from
Oct 16, 2021
Merged

[7.x] Update Security/Cases deprecation message #115250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f4ad99
Update Security/Cases deprecation message
jportner Oct 15, 2021
beda140
Fix unit tests
jportner Oct 15, 2021
c92a5f2
Fix Jest test again...
jportner Oct 15, 2021
bda86a7
Merge branch '7.x' into update-security-cases-deprecation
kibanamachine Oct 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions x-pack/plugins/security_solution/server/deprecation_privileges/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,8 +473,8 @@ describe('deprecations', () => {
},
"deprecationType": "feature",
"level": "warning",
"message": "The \\"Security\\" feature will be split into two separate features in 8.0. The \\"first_role\\" role grants access to this feature, and it needs to be updated before you upgrade Kibana. This will ensure that users have access to the same features after the upgrade.",
"title": "The \\"first_role\\" role needs to be updated",
"message": "The Security feature will be split into the Security and Cases features in 8.0. The \\"first_role\\" role grants access to the Security feature only. Update the role to also grant access to the Cases feature.",
"title": "The Security feature is changing, and the \\"first_role\\" role requires an update",
},
]
`);
Expand Down Expand Up @@ -608,8 +608,8 @@ describe('deprecations', () => {
},
"deprecationType": "feature",
"level": "warning",
"message": "The \\"Security\\" feature will be split into two separate features in 8.0. The \\"second_role\\" role grants access to this feature, and it needs to be updated before you upgrade Kibana. This will ensure that users have access to the same features after the upgrade.",
"title": "The \\"second_role\\" role needs to be updated",
"message": "The Security feature will be split into the Security and Cases features in 8.0. The \\"second_role\\" role grants access to the Security feature only. Update the role to also grant access to the Cases feature.",
"title": "The Security feature is changing, and the \\"second_role\\" role requires an update",
},
]
`);
Expand Down Expand Up @@ -772,13 +772,13 @@ describe('deprecations', () => {
});
const response = await getDeprecations(mockContext);
expect(response).toEqual([
expect.objectContaining({ title: 'The "role_siem_all" role needs to be updated' }),
expect.objectContaining({ title: 'The "role_siem_read" role needs to be updated' }),
expect.objectContaining({ message: expect.stringMatching(/"role_siem_all"/) }),
expect.objectContaining({ message: expect.stringMatching(/"role_siem_read"/) }),
expect.objectContaining({
title: 'The "role_siem_minimal_all_cases_all_cases_read" role needs to be updated',
message: expect.stringMatching(/"role_siem_minimal_all_cases_all_cases_read"/),
}),
expect.objectContaining({
title: 'The "role_siem_minimal_read_cases_read" role needs to be updated',
message: expect.stringMatching(/"role_siem_minimal_read_cases_read"/),
}),
// the fifth_role and sixth_role have been filtered out because they do not grant access to Cases
]);
Expand Down
5 changes: 3 additions & 2 deletions x-pack/plugins/security_solution/server/deprecation_privileges/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,15 +119,16 @@ export const registerPrivilegeDeprecations = ({
title: i18n.translate(
'xpack.securitySolution.privilegeDeprecations.casesSubFeaturePrivileges.title',
{
defaultMessage: 'The "{roleName}" role needs to be updated',
defaultMessage:
'The Security feature is changing, and the "{roleName}" role requires an update',
values: { roleName },
}
),
message: i18n.translate(
'xpack.securitySolution.privilegeDeprecations.casesSubFeaturePrivileges.message',
{
defaultMessage:
'The "Security" feature will be split into two separate features in 8.0. The "{roleName}" role grants access to this feature, and it needs to be updated before you upgrade Kibana. This will ensure that users have access to the same features after the upgrade.',
'The Security feature will be split into the Security and Cases features in 8.0. The "{roleName}" role grants access to the Security feature only. Update the role to also grant access to the Cases feature.',
values: { roleName },
}
),
Expand Down