[Controls] Options List Redux & Selection Management#115122
[Controls] Options List Redux & Selection Management#115122ThomThomson merged 19 commits intoelastic:masterfrom
Conversation
…ction clear buttons to options list. Options list clears selections when field or index pattern change
ThomThomson
added
Feature:Dashboard
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
...til/public/components/controls/control_types/options_list/options_list_popover_component.tsx
Show resolved
Hide resolved
…ol_types/options_list/options_list_popover_component.tsx Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
|
@elasticmachine merge upstream |
[Controls] Add empty state and do cleanup
...ins/presentation_util/public/components/controls/control_group/editor/edit_control_group.tsx
Outdated
Show resolved
Hide resolved
| singleSelect?: boolean; | ||
|
|
||
| indexPatternSelectOptions: Array<EuiSuperSelectOption<string>>; | ||
| availableIndexPatterns?: { [key: string]: IIndexPattern }; |
There was a problem hiding this comment.
Not necessarily a thing to change but when do we wanna switch from IndexPattern stuff to DataView stuff? Is it just a 1-1 conversion?
There was a problem hiding this comment.
I've switched over to the DataView format during the dashboard integration PR. #115477 is temporarily open to check for CI failures, you can take a look at the diff there!
poffdeluxe
left a comment
poffdeluxe
left a comment
There was a problem hiding this comment.
Code LGTM and works great!
...entation_util/public/components/controls/control_group/component/control_group_component.tsx
Outdated
Show resolved
Hide resolved
...entation_util/public/components/controls/control_group/component/control_group_component.tsx
Outdated
Show resolved
Hide resolved
|
You'll also need to add |
|
Added the flex group changes, good call, It looks a lot better in small sizes now! |
|
@ryankeairns I tested how a subdued panel would look like for the empty state, like we discussed. The subdued color is actually the same background color as Kibana so there's no contrast which isn't something bad per se. What do you think?
|
andreadelrio
left a comment
andreadelrio
left a comment
There was a problem hiding this comment.
Approving now as we will have a follow-up PR to continue refining the design side of this.
|
@andreadelrio @ryankeairns, I do like the design of the panel without a background color. In the dashboard implementation PR, I was also experimenting with removing the background by setting its color to transparent, and removing the drop shadow - as I think it adds a bit too much noise, and each individual control already has a
The problem that @andreadelrio found with this approach is that when dragging a control, not having a background could make it look like the controls can be dragged anywhere, when the drop zone is only the top. I am not sure how we can solve this, but I think if we go the route of removing the background in some cases, it should be removed in all cases. |
|
@elasticmachine merge upstream |
ryankeairns
left a comment
ryankeairns
left a comment
There was a problem hiding this comment.
LGTM. I like the background-color-while-dragging design that Andrea shared during the sync. Also, +1 to more polish after merging / viewing in the full context of Kibana.
💚 Build Succeeded
Metrics [docs]History
To update your PR or re-run it, just comment with: |
6 participants
fixes #113489
Summary
This PR is a follow-up to #114371 which adds redux toolkit integration to the Options list control.
Additionally, this PR provides a couple user-facing changes
Options List "show selections only" mode
Options List clear all button
Removed Jumpy Loading
On each keystroke, when the typeahead would trigger, the loading indicator would show instead of the available options.
The loading indicator now shows over top of the available options, keeping the same size. This should reduce jumpiness when typing.
Confirm on delete Control
