[Security Solution] Make new Add Data page more fine grained by kevinlog · Pull Request #115016 · elastic/kibana

kevinlog · 2021-10-14T14:09:07Z

Summary

This PR makes the new Add Data page more fine grained in the Security app. Before, the page covered the entire app which changed some workflows. After gathering feedback from the Security team and PMs, this change only adds the new empty state to pages that already used the empty state.

In addition, there is a new hook to detect pages at the top level which use the empty state to ensure that the background color is subdued to match that of the Empty State.

Overview page:

Hosts page:

Network page:

Timelines page:

Examples of some pages that didn't have the empty state before now restored when !indicesExist:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2021-10-14T14:09:10Z

Pinging @elastic/security-detections-response (Team:Detections and Resp)

elasticmachine · 2021-10-14T14:09:10Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

elasticmachine · 2021-10-14T14:09:10Z

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

cchaos · 2021-10-14T15:27:14Z

@kevinlog FYI, there is some general work being done to the Add Data cards that will overlap with this work. #114911. @snide has taken that PR over for me since I'm out the rest of the week. But there might need to be some coordination there.

kevinlog · 2021-10-14T16:35:43Z

@elasticmachine merge upstream

jonathan-buttner · 2021-10-14T18:32:51Z

.../plugins/security_solution/public/common/utils/empty_view/use_show_pages_with_empty_view.tsx

+    }
+  }, [pageName, indicesExist]);
+
+  return [showEmptyState];


Since we're only returning a single boolean here would it make sense to do return showEmptyState instead of having it as an array?

…log/kibana into task/make-empty-page-finer-grained

jonathan-buttner

Code changes look good to me!

xcrzx

I checkout and tested this PR locally, and detection pages are now not covered by the Add Data screen when users have insufficient privileges. I added a couple of nits, but everything else looks good to me 👍

This PR, however, doesn't address this issue when users see the Add Data screen on other pages when they don't have enough privileges. But this is likely out of the scope of this work and could be handled separately.

.../plugins/security_solution/public/common/utils/empty_view/use_show_pages_with_empty_view.tsx

XavierM · 2021-10-15T17:18:59Z

@xcrzx This PR should take care of the privileges but only in 8.0.0

kevinlog · 2021-10-18T11:59:38Z

@elasticmachine merge upstream

kevinlog · 2021-10-18T13:41:22Z

@elasticmachine merge upstream

kevinlog · 2021-10-19T01:04:55Z

@elasticmachine merge upstream

kevinlog · 2021-10-19T01:10:36Z

@elasticmachine merge upstream

…make-empty-page-finer-grained

cchaos · 2021-10-19T09:07:32Z

@elasticmachine merge upstream

cchaos

The code changes LGTM (I also pushed a fix from the rebase). I'll leave it up to the Security team to decide which pages benefit from the "No data" screen.

Dosant

App services code change lgtm

kevinlog · 2021-10-19T11:25:39Z

@elasticmachine merge upstream

kevinlog · 2021-10-19T12:57:47Z

@elasticmachine merge upstream

kevinlog · 2021-10-19T14:30:20Z

@elasticmachine merge upstream

kibanamachine · 2021-10-19T17:01:57Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 49599e1
Storybooks Preview
Documentation Changes
Flaky suites:
- xpack-kibana-ciGroup6

Test Failures

Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/jobs/categorization_field_examples·ts.apis Machine Learning jobs Categorization example endpoint - partially valid, more than 75% are null

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]     │
[00:00:00]       └-: apis
[00:00:00]         └-> "before all" hook in "apis"
[00:11:58]         └-: Machine Learning
[00:11:58]           └-> "before all" hook in "Machine Learning"
[00:11:58]           └-> "before all" hook in "Machine Learning"
[00:11:58]             │ debg creating role ft_ml_source
[00:11:58]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_source]
[00:11:58]             │ debg creating role ft_ml_source_readonly
[00:11:58]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_source_readonly]
[00:11:58]             │ debg creating role ft_ml_dest
[00:11:58]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_dest]
[00:11:58]             │ debg creating role ft_ml_dest_readonly
[00:11:58]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_dest_readonly]
[00:11:58]             │ debg creating role ft_ml_ui_extras
[00:11:58]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_ui_extras]
[00:11:58]             │ debg creating role ft_default_space_ml_all
[00:11:58]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_all]
[00:11:58]             │ debg creating role ft_default_space1_ml_all
[00:11:58]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space1_ml_all]
[00:11:58]             │ debg creating role ft_all_spaces_ml_all
[00:11:58]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_all_spaces_ml_all]
[00:11:58]             │ debg creating role ft_default_space_ml_read
[00:11:58]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_read]
[00:11:58]             │ debg creating role ft_default_space1_ml_read
[00:11:58]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space1_ml_read]
[00:11:58]             │ debg creating role ft_all_spaces_ml_read
[00:11:58]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_all_spaces_ml_read]
[00:11:58]             │ debg creating role ft_default_space_ml_none
[00:11:58]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_none]
[00:11:58]             │ debg creating user ft_ml_poweruser
[00:11:58]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser]
[00:11:58]             │ debg created user ft_ml_poweruser
[00:11:58]             │ debg creating user ft_ml_poweruser_spaces
[00:11:58]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_spaces]
[00:11:58]             │ debg created user ft_ml_poweruser_spaces
[00:11:58]             │ debg creating user ft_ml_poweruser_space1
[00:11:58]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_space1]
[00:11:58]             │ debg created user ft_ml_poweruser_space1
[00:11:58]             │ debg creating user ft_ml_poweruser_all_spaces
[00:11:58]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_all_spaces]
[00:11:58]             │ debg created user ft_ml_poweruser_all_spaces
[00:11:58]             │ debg creating user ft_ml_viewer
[00:11:59]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer]
[00:11:59]             │ debg created user ft_ml_viewer
[00:11:59]             │ debg creating user ft_ml_viewer_spaces
[00:11:59]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_spaces]
[00:11:59]             │ debg created user ft_ml_viewer_spaces
[00:11:59]             │ debg creating user ft_ml_viewer_space1
[00:11:59]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_space1]
[00:11:59]             │ debg created user ft_ml_viewer_space1
[00:11:59]             │ debg creating user ft_ml_viewer_all_spaces
[00:11:59]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_all_spaces]
[00:11:59]             │ debg created user ft_ml_viewer_all_spaces
[00:11:59]             │ debg creating user ft_ml_unauthorized
[00:11:59]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_unauthorized]
[00:11:59]             │ debg created user ft_ml_unauthorized
[00:11:59]             │ debg creating user ft_ml_unauthorized_spaces
[00:11:59]             │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_unauthorized_spaces]
[00:11:59]             │ debg created user ft_ml_unauthorized_spaces
[00:16:23]           └-: jobs
[00:16:23]             └-> "before all" hook in "jobs"
[00:16:23]             └-: Categorization example endpoint - 
[00:16:23]               └-> "before all" hook for "valid with good number of tokens"
[00:16:23]               └-> "before all" hook for "valid with good number of tokens"
[00:16:23]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Loading "mappings.json"
[00:16:23]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Loading "data.json.gz"
[00:16:23]                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [ft_categorization] creating index, cause [api], templates [], shards [1]/[0]
[00:16:23]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Created index "ft_categorization"
[00:16:23]                 │ debg [x-pack/test/functional/es_archives/ml/categorization] "ft_categorization" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:16:24]                 │ info [x-pack/test/functional/es_archives/ml/categorization] Indexed 1501 docs into "ft_categorization"
[00:16:24]                 │ debg applying update to kibana config: {"dateFormat:tz":"UTC"}
[00:16:25]               └-> valid with good number of tokens
[00:16:25]                 └-> "before each" hook: global before each for "valid with good number of tokens"
[00:16:25]                 └- ✓ pass  (213ms)
[00:16:25]               └-> invalid, too many tokens.
[00:16:25]                 └-> "before each" hook: global before each for "invalid, too many tokens."
[00:16:25]                 │ info [r.suppressed] [node-01] path: /_analyze, params: {}
[00:16:25]                 │      org.elasticsearch.transport.RemoteTransportException: [node-01][127.0.0.1:63201][indices:admin/analyze[s]]
[00:16:25]                 │      Caused by: java.lang.IllegalStateException: The number of tokens produced by calling _analyze has exceeded the allowed maximum of [10000]. This limit can be set by changing the [index.analyze.max_token_count] index level setting.
[00:16:25]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction$TokenCounter.increment(TransportAnalyzeAction.java:397) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.simpleAnalyze(TransportAnalyzeAction.java:229) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.analyze(TransportAnalyzeAction.java:204) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.analyze(TransportAnalyzeAction.java:122) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.shardOperation(TransportAnalyzeAction.java:110) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.shardOperation(TransportAnalyzeAction.java:62) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction.lambda$asyncShardOperation$0(TransportSingleShardAction.java:99) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.ActionRunnable.lambda$supply$0(ActionRunnable.java:47) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.ActionRunnable$2.doRun(ActionRunnable.java:62) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:737) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:26) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
[00:16:25]                 │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
[00:16:25]                 │      	at java.lang.Thread.run(Thread.java:833) [?:?]
[00:16:25]                 │ info [r.suppressed] [node-01] path: /_analyze, params: {}
[00:16:25]                 │      org.elasticsearch.transport.RemoteTransportException: [node-01][127.0.0.1:63201][indices:admin/analyze[s]]
[00:16:25]                 │      Caused by: java.lang.IllegalStateException: The number of tokens produced by calling _analyze has exceeded the allowed maximum of [10000]. This limit can be set by changing the [index.analyze.max_token_count] index level setting.
[00:16:25]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction$TokenCounter.increment(TransportAnalyzeAction.java:397) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.simpleAnalyze(TransportAnalyzeAction.java:229) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.analyze(TransportAnalyzeAction.java:204) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.analyze(TransportAnalyzeAction.java:122) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.shardOperation(TransportAnalyzeAction.java:110) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.admin.indices.analyze.TransportAnalyzeAction.shardOperation(TransportAnalyzeAction.java:62) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction.lambda$asyncShardOperation$0(TransportSingleShardAction.java:99) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.ActionRunnable.lambda$supply$0(ActionRunnable.java:47) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.action.ActionRunnable$2.doRun(ActionRunnable.java:62) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:737) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:26) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:16:25]                 │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
[00:16:25]                 │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
[00:16:25]                 │      	at java.lang.Thread.run(Thread.java:833) [?:?]
[00:16:25]                 └- ✓ pass  (215ms)
[00:16:25]               └-> partially valid, more than 75% are null
[00:16:25]                 └-> "before each" hook: global before each for "partially valid, more than 75% are null"
[00:16:25]                 └- ✖ fail: apis Machine Learning jobs Categorization example endpoint -  partially valid, more than 75% are null
[00:16:25]                 │       Error: expected 249 to sort of equal 250
[00:16:25]                 │       + expected - actual
[00:16:25]                 │ 
[00:16:25]                 │       -249
[00:16:25]                 │       +250
[00:16:25]                 │       
[00:16:25]                 │       at Assertion.assert (/dev/shm/workspace/parallel/20/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:16:25]                 │       at Assertion.eql (/dev/shm/workspace/parallel/20/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:16:25]                 │       at Context.<anonymous> (test/api_integration/apis/ml/jobs/categorization_field_examples.ts:303:36)
[00:16:25]                 │       at runMicrotasks (<anonymous>)
[00:16:25]                 │       at processTicksAndRejections (node:internal/process/task_queues:96:5)
[00:16:25]                 │       at Object.apply (/dev/shm/workspace/parallel/20/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:16:25]                 │ 
[00:16:25]                 │

Stack Trace

Error: expected 249 to sort of equal 250
    at Assertion.assert (/dev/shm/workspace/parallel/20/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/20/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at Context.<anonymous> (test/api_integration/apis/ml/jobs/categorization_field_examples.ts:303:36)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (/dev/shm/workspace/parallel/20/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16) {
  actual: '249',
  expected: '250',
  showDiff: true
}

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2764	2765	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	4.6MB	4.6MB	-69.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kibanaReact`	80.9KB	80.9KB	+32.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…#115016) * [Security Solution] Make new Add Data page more fine grained

kibanamachine · 2021-10-19T17:05:20Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

#115606) * [Security Solution] Make new Add Data page more fine grained Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com>

[Security Solution] Make new Add Data page more fine grained

b067b98

kevinlog added release_note:enhancement v8.0.0 Team:Detections and Resp Security Detection Response Team Team:Threat Hunting Security Solution Threat Hunting Team Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.16.0 labels Oct 14, 2021

kevinlog requested a review from a team as a code owner October 14, 2021 14:09

kevinlog requested a review from cchaos October 14, 2021 14:09

remove unused code

cf6d00a

Merge branch 'master' into task/make-empty-page-finer-grained

70c01e1

banderror mentioned this pull request Oct 14, 2021

[Security Solution] "No Data" screen is displayed when a user has missing privileges #114960

Closed

jonathan-buttner reviewed Oct 14, 2021

View reviewed changes

kevinlog added 2 commits October 14, 2021 15:22

pr comments

ebeaae0

Merge branch 'task/make-empty-page-finer-grained' of github.com:kevin…

ee6fd3a

…log/kibana into task/make-empty-page-finer-grained

jonathan-buttner approved these changes Oct 14, 2021

View reviewed changes

xcrzx approved these changes Oct 15, 2021

View reviewed changes

.../plugins/security_solution/public/common/utils/empty_view/use_show_pages_with_empty_view.tsx Outdated Show resolved Hide resolved

.../plugins/security_solution/public/common/utils/empty_view/use_show_pages_with_empty_view.tsx Outdated Show resolved Hide resolved

xcrzx mentioned this pull request Oct 15, 2021

[BUG] Outdated privileges list on the "Detections prerequisites and requirements" page elastic/security-docs#1158

Closed

XavierM mentioned this pull request Oct 15, 2021

[SECURITY SOLUTION] [CASES] Allow cases to be there when security solutions privileges is none #113573

Merged

1 task

kevinlog added 2 commits October 15, 2021 16:47

pr comments

422c538

pr comments

0969188

Merge branch 'master' into task/make-empty-page-finer-grained

1c30c6d

Merge branch 'master' into task/make-empty-page-finer-grained

85c08e7

kevinlog added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 18, 2021

Merge branch 'master' into task/make-empty-page-finer-grained

607bb82

kibanamachine and others added 4 commits October 18, 2021 21:10

Merge branch 'master' into task/make-empty-page-finer-grained

e0194a2

Merge branch 'master' of https://github.com/elastic/kibana into task/…

2a6ad51

…make-empty-page-finer-grained

Add category back in for integration URL and snap

bb2ac37

Fix category placement

e3b79fc

Merge branch 'master' into task/make-empty-page-finer-grained

43b0b85

cchaos approved these changes Oct 19, 2021

View reviewed changes

Dosant approved these changes Oct 19, 2021

View reviewed changes

kibanamachine and others added 2 commits October 19, 2021 07:25

Merge branch 'master' into task/make-empty-page-finer-grained

e5c2b58

fix test

ae3b524

Merge branch 'master' into task/make-empty-page-finer-grained

1771206

kevinlog mentioned this pull request Oct 19, 2021

[Security Solution]User is unable to navigate to different tabs. #115503

Closed

Merge branch 'master' into task/make-empty-page-finer-grained

49599e1

kevinlog enabled auto-merge (squash) October 19, 2021 15:16

kevinlog merged commit 9bc4865 into elastic:master Oct 19, 2021

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 19, 2021

[Security Solution] Make new Add Data page more fine grained (elastic…

ef24a29

…#115016) * [Security Solution] Make new Add Data page more fine grained

kibanamachine mentioned this pull request Oct 19, 2021

[7.x] [Security Solution] Make new Add Data page more fine grained (#115016) #115606

Merged

kevinlog deleted the task/make-empty-page-finer-grained branch October 19, 2021 17:13

kevinlog mentioned this pull request Oct 19, 2021

[Security Solution]User is unable to view alerts tab if agent is not installed #115502

Closed

Conversation

kevinlog commented Oct 14, 2021

Summary

Checklist

Uh oh!

elasticmachine commented Oct 14, 2021

Uh oh!

elasticmachine commented Oct 14, 2021

Uh oh!

elasticmachine commented Oct 14, 2021

Uh oh!

cchaos commented Oct 14, 2021

Uh oh!

kevinlog commented Oct 14, 2021

Uh oh!

jonathan-buttner Oct 14, 2021

Choose a reason for hiding this comment

Uh oh!

kevinlog Oct 14, 2021

Choose a reason for hiding this comment

Uh oh!

jonathan-buttner left a comment

Choose a reason for hiding this comment

Uh oh!

xcrzx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

XavierM commented Oct 15, 2021

Uh oh!

kevinlog commented Oct 18, 2021

Uh oh!

kevinlog commented Oct 18, 2021

Uh oh!

kevinlog commented Oct 19, 2021

Uh oh!

kevinlog commented Oct 19, 2021

Uh oh!

cchaos commented Oct 19, 2021

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

Dosant left a comment

Choose a reason for hiding this comment

Uh oh!

kevinlog commented Oct 19, 2021

Uh oh!

kevinlog commented Oct 19, 2021

Uh oh!

kevinlog commented Oct 19, 2021

Uh oh!

kibanamachine commented Oct 19, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

kibanamachine commented Oct 19, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants