chore(NA): improve kbn-ui-shared-deps-npm split#114557
Merged
mistic merged 11 commits intoelastic:masterfrom Oct 13, 2021
Merged
chore(NA): improve kbn-ui-shared-deps-npm split#114557mistic merged 11 commits intoelastic:masterfrom
mistic merged 11 commits intoelastic:masterfrom
Conversation
mistic
added
chore
Team:Operations
spalger
reviewed
Oct 11, 2021
| const MOMENT_SRC = require.resolve('moment/min/moment-with-locales.js'); | ||
| const WEBPACK_SRC = require.resolve('webpack'); | ||
|
|
||
| const REPO_ROOT = Path.resolve(__dirname, '..', '..'); |
Contributor
There was a problem hiding this comment.
I would love if we didn't need to reimplement this anyplace we use it, maybe in the future we could make a dev-path-constants package or something to encapsulate this very unlikely to change state?
Contributor
Author
There was a problem hiding this comment.
👍 yeah I like the idea! My effort here was only try to decouple @kbn/utils from the @kbn/ui-shared-deps-npm
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Contributor
Author
|
@spalger do you think we can move on this one? |
spalger
approved these changes
Oct 12, 2021
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 13, 2021
* chore(NA): remove elastic-datemath from kbn-ui-shared-deps-npm * chore(NA): remove @kbn deps on kbn ui shared deps npm * chore(NA): missing peer dep to build kbn ui shared deps npm * chore(NA): general improvements for kbn ui shared deps npm * chore(NA): remove min size chunks plugin * chore(NA): remove split chunks * chore(NA): improve dep declaring on kbn-ui-shared-deps-src * chore(NA): remove typo Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 13, 2021
* chore(NA): remove elastic-datemath from kbn-ui-shared-deps-npm * chore(NA): remove @kbn deps on kbn ui shared deps npm * chore(NA): missing peer dep to build kbn ui shared deps npm * chore(NA): general improvements for kbn ui shared deps npm * chore(NA): remove min size chunks plugin * chore(NA): remove split chunks * chore(NA): improve dep declaring on kbn-ui-shared-deps-src * chore(NA): remove typo Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working with packages I noticed that our previous
kbn-ui-shared-depssplit could be improved in a couple of places.It would be really cool if we can find ways we can lower the build times of those splits in the future, specially the
kbn-ui-shared-deps-srcas it will compound with the package build trees of a considerable amount of packages.