Skip to content

Added Component Integration Test for Flush Action in Index Management#114401

Merged
cuff-links merged 8 commits intoelastic:masterfrom
cuff-links:Add_CIT_For_Flush_Indices_Index_Management
Oct 15, 2021
Merged

Added Component Integration Test for Flush Action in Index Management#114401
cuff-links merged 8 commits intoelastic:masterfrom
cuff-links:Add_CIT_For_Flush_Indices_Index_Management

Conversation

@cuff-links
Copy link
Contributor

@cuff-links cuff-links commented Oct 8, 2021

Summary

This PR adds a component integration test that checks that we are able to click the flush index button and check the last request to ensure that it was made to the flush index API.

@cuff-links cuff-links added v7.15.1 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// Feature:Index Management Index and index templates UI auto-backport Deprecated - use backport:version if exact versions are needed test-jest-integration release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Oct 8, 2021
@cuff-links cuff-links marked this pull request as ready for review October 9, 2021 02:51
@cuff-links cuff-links requested a review from a team as a code owner October 9, 2021 02:51
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 9, 2021

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@cuff-links
Copy link
Contributor Author

cuff-links commented Oct 12, 2021

@elasticmachine merge upstream

sabarasaba
sabarasaba reviewed Oct 12, 2021
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @cuff-links! Changes LGTM, just had a suggestions for simplifying the button selector and maybe abstracting the clicking logic into a new action:

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 15, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cuff-links cuff-links requested review from sabarasaba and removed request for cjcenizal October 15, 2021 05:31
sabarasaba
sabarasaba approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm!

@cuff-links cuff-links merged commit 98acb5d into elastic:master Oct 15, 2021
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 15, 2021

The following labels were identified as gaps in your version labels and will be added automatically:

  • v7.16.0

If any of these should not be on your pull request, please manually remove them.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 21, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

26 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 22, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 25, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 26, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 27, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 28, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 29, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 1, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 2, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 3, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 4, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 5, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 8, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 9, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 10, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 11, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 12, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 15, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 16, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 17, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 18, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 19, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 22, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 23, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 24, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 25, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 26, 2021

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@sebelga sebelga added the backport:skip This PR does not require backporting label Nov 29, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 29, 2021
tylersmalley pushed a commit that referenced this pull request Dec 14, 2021
@kibanamachine
Added Component Integration Test for Flush Action in Index Management (…
76b3cc2 
…#114401) (#115248)

* Aded some data test subjects for the test.

* Added flush indices test.

* Fixed linting issue.

* Merged test subject PR in and updated tests.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: John Dorlus <silne.dorlus@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

@yuliacech yuliacech Awaiting requested review from yuliacech

@sebelga sebelga Awaiting requested review from sebelga

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This PR does not require backporting Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// test-jest-integration v7.15.1 v7.16.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cuff-links @elasticmachine @kibanamachine @sabarasaba @sebelga