Skip to content

[Bazel] Only persist cache and create build invocations in on-merge pipeline#114035

Merged
tylersmalley merged 3 commits intoelastic:masterfrom
tylersmalley:bazel-caching-updates
Oct 7, 2021
Merged

[Bazel] Only persist cache and create build invocations in on-merge pipeline#114035
tylersmalley merged 3 commits intoelastic:masterfrom
tylersmalley:bazel-caching-updates

Conversation

@tylersmalley
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley commented Oct 5, 2021

[skip-ci]

Also enables remote cache for Linux developers

This should drastically cut down on our BuildBuddy build invocation count.

@tylersmalley tylersmalley force-pushed the bazel-caching-updates branch from 621a7e6 to 34a0dba Compare October 5, 2021 23:57
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley changed the title [Bazel] Enables Linux remote caching [Bazel] Only persist cache and create build invocations in on-merge pipeline Oct 6, 2021
@tylersmalley tylersmalley requested a review from mistic October 6, 2021 05:32
@tylersmalley tylersmalley added Team:Operations Kibana-Operations Team v7.16.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels Oct 6, 2021
@tylersmalley tylersmalley force-pushed the bazel-caching-updates branch from 34a0dba to 176e0be Compare October 6, 2021 05:33
set -euo pipefail

# Write Bazel cache for Linux
.buildkite/scripts/common/setup_bazel.sh
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any plans to enable this for macOS soon too?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, no timeline yet, though

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to get the usage under control first.

@tylersmalley
Copy link
Copy Markdown
Member Author

From build, verifying cache still works:

https://buildkite.com/elastic/kibana-pull-request/builds/106#04ea1d3f-d856-4569-b25e-a25abddc274e

info [bazel] INFO: 726 processes: 477 remote cache hit, 210 internal, 39 linux-sandbox.

@elastic elastic deleted a comment from kibanamachine Oct 6, 2021
@tylersmalley tylersmalley marked this pull request as ready for review October 6, 2021 18:27
@tylersmalley tylersmalley requested a review from a team as a code owner October 6, 2021 18:27
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It now LGTM

@tylersmalley tylersmalley merged commit 4c66da4 into elastic:master Oct 7, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 7, 2021
…ipeline (elastic#114035)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 7, 2021
…erge pipeline (#114035) (#114339)

* [Bazel] Only persist cache and create build invocations in on-merge pipeline (#114035)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* [ci] Fix setup_bazel permissions

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed buildkite-ci release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.16.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants