Update dependency @elastic/charts to v37 (master) #113968
Update dependency @elastic/charts to v37 (master) #113968markov00 merged 17 commits intoelastic:masterfrom
Conversation
| const allPieSlicesColor = await pieChart.getAllPieSliceColor('80,000'); | ||
| const whitePieSliceCounts = allPieSlicesColor.reduce((count, color) => { | ||
| // converting the color to a common format, testing the color, not the string format | ||
| return chroma(color).hex().toUpperCase() === '#FFFFFF' ? count + 1 : count; | ||
| }, 0); |
There was a problem hiding this comment.
I've relaxed this check to verify that the color on the slice is white removing the check of the actual color string format.
getAllPieSliceStyles was also renamed to getAllPieSliceColor because we always return a set of colors, not styles
|
@elasticmachine merge upstream |
|
Pinging @elastic/apm-ui (Team:apm) |
shahzad31
left a comment
There was a problem hiding this comment.
Uptime Changes LGTM !!
| ); | ||
|
|
||
| const onBrushEnd: BrushEndListener = ({ x }) => { | ||
| const onBrushEnd = ({ x }: XYBrushEvent) => { |
There was a problem hiding this comment.
Why remove BrushEndListener here if it is force casted below then?
There was a problem hiding this comment.
At the moment we have two ways of doing that:
- force casting it as
BrushEndListener - force casting the arguments of the BrushEndListener to XYBrushEvent
Both methods are not ideal at the moment. We will introduce soon a better type system for those union types (probably through a property to discriminate between union types)
There was a problem hiding this comment.
Yes, I understand that. I was asking as in this component both routes have been chosen: force casting the arguments and few lines below force casting the function.
My point was: can we leave the force cast in one place rather than duplicate?
Not a big blocker, just curious on the reasons of the move.
kertal
left a comment
There was a problem hiding this comment.
Data Discovery team owned files LGTM, just type changes. Didn't test.
sabarasaba
left a comment
There was a problem hiding this comment.
watcher changes lgtm, didn't test locally
Something flaky is going on with the last CI run |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream unrelated issues in CI |
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/index_lifecycle_management·ts.Index Lifecycle Management "before all" hook for "Add policy to index template modal"Standard OutStack TraceKibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/index_lifecycle_management·ts.Index Lifecycle Management "after all" hook for "Index templates flyout"Standard OutStack TraceKibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/index_lifecycle_management·ts.Index Lifecycle Management "before all" hook for "Add policy to index template modal"Standard OutStack Traceand 2 more failures, only showing the first 3. Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
dej611
left a comment
There was a problem hiding this comment.
Discussed offline about the typings thing and sorted out.
Tested locally and all good. 👍
ThomThomson
left a comment
There was a problem hiding this comment.
Presentation team changes LGTM! Anything that makes the dashboard_state functional test better is a win in my books, thanks for doing this @markov00
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
[skip-ci]
This PR contains the following updates:
34.2.1->37.0.0The code changes are due to the following
@elastic/chartsbreaking changes:the
textContrasttextInvertibleandtextOpacityin theFonttype has been removed. This affect theHeatmapConfigtype in thecell.label,xAxisLabel, andyAxisLabelproperties. This also affect thePartitionConfigproperties:fillLabelandlinkLabel. ThetextInvertibleandtextContrastproperties are also removed from theDisplayValueStyleused to display bar values labels. The mentioned changes are replaced with the following behavior: always invert the text color depending on the color contrast with its background using pureblackorwhitecolors.on
Heatmaptheconfig.label.fontSizeprop is replaced byconfig.label.minFontSizeandconfig.label.maxFontSize. You can specify the same value for both properties to have a fixed font size.The
config.label.alignandconfig.label.baselineprops are removed from theHeatmapConfigobject. These props handle the alignment of the text within the text and they are not currently compatible with the font size scaling feature introduced. Is not very common to change the alignment of text within rectangular boxes where the centered option is the most used oneon
HeatmaptheonBrushEndprops was moved from theconfigto theSettings. TheonBrushEndListenerprop signature was changed totype BrushEndListener = (brushEvent: XYBrushEvent | HeatmapBrushEvent) => void;The public type varieties for domains are discontinued, in favor of retaining the single
DomainRangeexport, which now has a mandatory{min: number, max: number}. The developer can supplyNaNwhere a finite min, max or both aren't defined (ie. in place of former effectiveundefined)Release Notes
elastic/elastic-charts
37.0.0 (2021-10-05)
Bug Fixes
Code Refactoring
BREAKING CHANGES
DEFAULT_CHART_MARGINS,DEFAULT_GEOMETRY_STYLES,DEFAULT_CHART_PADDINGandDEFAULT_MISSING_COLORare no longer exposed as part of the APIDomainRangeexport, which now has a mandatory{min: number, max: number}. The developer can supplyNaNwhere a finite min, max or both aren't defined (ie. in place of former effectiveundefined). In addition, some console.warn punctuations changedCo-authored-by: Marco Vettorello vettorello.marco@gmail.com
Co-authored-by: Nick Partridge nick.ryan.partridge@gmail.com
36.0.0 (2021-09-15)
Features
BREAKING CHANGES
35.0.0 (2021-09-13)
Bug Fixes
Features
BREAKING CHANGES
showDuplicatedTickscauses a duplication check on the actual axis tick label (possibly yielded byAxis.tickLabelrather than the more generaltickFormat)config.label.fontSizeprop is replaced byconfig.label.minFontSizeandconfig.label.maxFontSize. You can specify the same value for both properties to have a fixed font size. Theconfig.label.alignandconfig.label.baselineprops are removed from theHeatmapConfigobject.