Skip to content

fix(NA): @kbn/monaco types exports#113937

Merged
mistic merged 1 commit intoelastic:masterfrom
mistic:fix-kbn-monaco-types-exprot
Oct 6, 2021
Merged

fix(NA): @kbn/monaco types exports#113937
mistic merged 1 commit intoelastic:masterfrom
mistic:fix-kbn-monaco-types-exprot

Conversation

@mistic
Copy link
Contributor

@mistic mistic commented Oct 5, 2021

This PR fixes the types export layout for @kbn/monaco. Currently and since we broke kbn-ui-shared-deps and moved into building the package with babel we were getting the following warnings during the build:

info [bazel] WARNING in /private/var/tmp/_bazel_/e81b6a886b074390725115607d34098d/sandbox/darwin-sandbox/138/execroot/kibana/node_modules/@kbn/monaco/target_web/index.js 18:0-83
 info [bazel] "export 'CompleteLangModule' (reexported as 'CompleteLangModuleType') was not found in './types'
 info [bazel]
 info [bazel] WARNING in /private/var/tmp/_bazel_/e81b6a886b074390725115607d34098d/sandbox/darwin-sandbox/138/execroot/kibana/node_modules/@kbn/monaco/target_web/index.js 18:0-83
 info [bazel] "export 'LangModule' (reexported as 'LangModuleType') was not found in './types'
 info [bazel]
 info [bazel] WARNING in /private/var/tmp/_bazel_/e81b6a886b074390725115607d34098d/sandbox/darwin-sandbox/138/execroot/kibana/node_modules/@kbn/monaco/target_web/painless/index.js 18:0-69
 info [bazel] "export 'PainlessAutocompleteField' was not found in './types'
 info [bazel]
 info [bazel] WARNING in /private/var/tmp/_bazel_/e81b6a886b074390725115607d34098d/sandbox/darwin-sandbox/138/execroot/kibana/node_modules/@kbn/monaco/target_web/painless/index.js 18:0-69
 info [bazel] "export 'PainlessContext' was not found in './types'

The current PR fixes the problem by removing the named exports from parts that will be removed by babel when transpiling the typescript files into js.

@mistic mistic added chore Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 5, 2021
@mistic mistic requested a review from jbudz October 5, 2021 13:52
@mistic mistic requested a review from a team as a code owner October 5, 2021 13:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.8MB 3.8MB -176.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit e594dee into elastic:master Oct 6, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 6, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 6, 2021
Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.16.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants