fix(NA): @kbn/monaco types exports#113937
Merged
mistic merged 1 commit intoelastic:masterfrom Oct 6, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Oct 5, 2021
yuliacech
approved these changes
Oct 5, 2021
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the types export layout for
@kbn/monaco. Currently and since we brokekbn-ui-shared-depsand moved into building the package with babel we were getting the following warnings during the build:The current PR fixes the problem by removing the named exports from parts that will be removed by babel when transpiling the typescript files into
js.