Skip to content

[App Search] Detail Page for Automated Curations#113885

Merged
byronhulcher merged 27 commits intoelastic:masterfrom
byronhulcher:automated-curation-detail
Oct 5, 2021
Merged

[App Search] Detail Page for Automated Curations#113885
byronhulcher merged 27 commits intoelastic:masterfrom
byronhulcher:automated-curation-detail

Conversation

@byronhulcher
Copy link
Copy Markdown
Contributor

@byronhulcher byronhulcher commented Oct 5, 2021

Summary

This is a re-make of #113550 after that PR was reverted

The Curation view has now split into the ManualCuration and AutomatedCuration views. ManualCuration is unchanged from the old Curation while AutomatedCuration is new, with the differences being:

  • Automated Badge
  • A "convert to manual" button
  • Buttons and other actions to modify the curation are hidden
  • Updated copy for when user cannot modify the curation

Screenshots

Screen Shot 2021-09-30 at 12 23 04 PM

Checklist

@byronhulcher byronhulcher added Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 5, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1504 1506 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.3MB 1.3MB +2.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@byronhulcher byronhulcher merged commit 81046f1 into elastic:master Oct 5, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 113885

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 7, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 113885 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 113885 or prevent reminders by adding the backport:skip label.

@byronhulcher
Copy link
Copy Markdown
Contributor Author

It's fine that this wasn't backported. I merged #113550 too quickly after another Automated Curations PR, and my PR had to be reverted. However the backport for #113550 to 7.x was fine. This is because the the existing Automated Curations PR had failed to backport because of conflicts. Since #113550 was never reverted on 7.x, we don't need to backport this PR.

@byronhulcher byronhulcher added the backport:skip This PR does not require backporting label Oct 8, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 8, 2021
@byronhulcher byronhulcher removed the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants