Fix long agent policy name accessibility in add/edit integration#113828
Merged
zizhouW merged 1 commit intoelastic:masterfrom Oct 6, 2021
zizhouW:issue-113820-long-agent-policy-name
Merged
Fix long agent policy name accessibility in add/edit integration#113828zizhouW merged 1 commit intoelastic:masterfrom zizhouW:issue-113820-long-agent-policy-name
zizhouW merged 1 commit intoelastic:masterfrom
zizhouW:issue-113820-long-agent-policy-name
Conversation
botelastic
bot
added
the
Team:Fleet
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
zizhouW
added
release_note:skip
Contributor
|
should we add auto-backport and v7.15.1 labels? |
Contributor
|
@zizhouW hi, could you check the mobile breakpoint as well? looks a bit weird aligned to the left (while Agent policy text aligned to the right), and there is more space for the name.
|
zizhouW
added
auto-backport
Author
|
@juliaElastic addressed the comment above. Thanks for pointing it out! |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Contributor
|
looks good now |
juliaElastic
approved these changes
Oct 6, 2021
kpollich
approved these changes
Oct 6, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 6, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 6, 2021
Contributor
|
Hi @jen-huang
Build details: Screenshot: cc: @EricDavisX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #113820 where long agent policy name pushes page title to the very left when on add/edit integrations page
Checklist
Delete any items that are not applicable to this PR.