add coreOverall$ to internal status contract#113729
add coreOverall$ to internal status contract#113729pgayvallet merged 5 commits intoelastic:masterfrom
coreOverall$ to internal status contract#113729Conversation
|
Pinging @elastic/kibana-core (Team:Core) |
| await statusPropagation(); | ||
| expect((await getStatus('statusPluginA')).level).to.eql('degraded'); | ||
| expect((await getStatus('statusPluginB')).level).to.eql('degraded'); |
There was a problem hiding this comment.
Same comment than #113214 (comment), still not sure how the PR changes introduced the added required delay, but...
| ); | ||
| expect(await setup.coreOverall$.pipe(first()).toPromise()).toMatchObject({ | ||
| level: ServiceStatusLevels.degraded, | ||
| summary: '[2] services are degraded', |
There was a problem hiding this comment.
That makes me think we should list the names of degraded services. To avoid unnecessary noise, we can trim the summary to a reasonable limit.
There was a problem hiding this comment.
Yea, that seems like a nice improvement. It may impact quite a few tests though, as we'll want to do the same for the global overall status, so I'll do it as a follow-up as soon as this one is merged.
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/monitoring/elasticsearch/nodes·js.Monitoring app Elasticsearch nodes listing with offline node should sort by nameStandard OutStack TraceMetrics [docs]
History
To update your PR or re-run it, just comment with: |
* add coreOverall$ to internal status contract * add unit tests * re-patch flaky tests * add and improve tests
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Summary
Fix #110583
Alternative to #113214
Add a new computed
coreOverall$status to the internal status contract and use it in the/api/statushandler to only return503when core services are unavailable.Checklist
Release Note
The
/api/statusendpoint will now only respond with a503status code if any Kibana core service is unavailable.