Update Index Management Tests to Check 4 Tabs on the Home Page#113692
Merged
cuff-links merged 3 commits intoelastic:masterfrom Oct 5, 2021
Merged
Conversation
cuff-links
added
Feature:Index Management
Contributor
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
yuliacech
approved these changes
Oct 5, 2021
Contributor
yuliacech
left a comment
yuliacech
left a comment
There was a problem hiding this comment.
Thanks a lot for fixing those tests, @cuff-links! Code changes LGTM 👍
Contributor
Author
|
@elaticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Contributor
|
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 5, 2021
…ic#113692) * Modified home page test to check for 4 tabs. * Fixed lint issue. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 5, 2021
…ic#113692) * Modified home page test to check for 4 tabs. * Fixed lint issue. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
kibanamachine
added a commit
that referenced
this pull request
Oct 5, 2021
…) (#113996) * Modified home page test to check for 4 tabs. * Fixed lint issue. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: John Dorlus <silne.dorlus@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 5, 2021
…) (#113995) * Modified home page test to check for 4 tabs. * Fixed lint issue. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: John Dorlus <silne.dorlus@elastic.co>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request is a follow up from #112010. It splits out the test to check for index management tabs. It was updated to do check all 4 tabs in index management from the previous 2.