[Cases][Timeline] Adding multiple-isolated changes#113552
[Cases][Timeline] Adding multiple-isolated changes#113552jonathan-buttner merged 6 commits intoelastic:masterfrom
Conversation
jonathan-buttner
added
v8.0.0
release_note:skip
jportner
left a comment
jportner
left a comment
There was a problem hiding this comment.
Code review only, LGTM!
For my future reference: this covers the following object types as outlined in #100489:
cases, cases-comments, cases-configure, cases-connector-mappings, cases-sub-case, cases-user-actions, siem-ui-timeline, siem-ui-timeline-note, siem-ui-timeline-pinned-event
| const theComments = await caseService.getAllCaseComments({ | ||
| unsecuredSavedObjectsClient, | ||
| id, | ||
| id: resolvedSavedObject.id, |
There was a problem hiding this comment.
In the case of an alias match the request's id and the resolvedSavedObject.id will be different. We'll want to use the resolvedSavedObject.id instead since that'll be pointing to the changed id.
|
@elasticmachine merge upstream |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-cases (Team:Threat Hunting:Cases) |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
6 participants
This PR implements step 4 for making cases and timeline share capable: https://www.elastic.co/guide/en/kibana/master/sharing-saved-objects.html#sharing-saved-objects-step-4
This also adds tests to ensure that the alias match case works appropriately.