-
Notifications
You must be signed in to change notification settings - Fork 8.6k
React beats instance view #113500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
matschaffer
merged 8 commits into
elastic:master
from
matschaffer:111757-beats-instance-view
Sep 30, 2021
Merged
React beats instance view #113500
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
90bf4f8
Add beat instance page
matschaffer cb40cc6
Fix beat instance tabs to match angular
matschaffer 5cd6ef7
Remove unused cluster prop on beats template
matschaffer 82fed2c
Fix breadcrumbs
matschaffer 6936241
Remove unused cluster prop
matschaffer 9676518
Merge branch 'master' into 111757-beats-instance-view
kibanamachine 76c66b2
Use correct codepath
matschaffer d6fb0b2
Switch beats instance back to use template
matschaffer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 changes: 90 additions & 0 deletions
90
x-pack/plugins/monitoring/public/application/pages/beats/instance.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import React, { useContext, useState, useCallback, useEffect } from 'react'; | ||
| import { useParams } from 'react-router-dom'; | ||
| import { i18n } from '@kbn/i18n'; | ||
| import { find } from 'lodash'; | ||
| import { ComponentProps } from '../../route_init'; | ||
| import { GlobalStateContext } from '../../global_state_context'; | ||
| import { useKibana } from '../../../../../../../src/plugins/kibana_react/public'; | ||
| import { useCharts } from '../../hooks/use_charts'; | ||
| // @ts-ignore | ||
| import { Beat } from '../../../components/beats/beat'; | ||
| import { BreadcrumbContainer } from '../../hooks/use_breadcrumbs'; | ||
| import { BeatsTemplate } from './beats_template'; | ||
|
|
||
| export const BeatsInstancePage: React.FC<ComponentProps> = ({ clusters }) => { | ||
| const { instance }: { instance: string } = useParams(); | ||
|
|
||
| const globalState = useContext(GlobalStateContext); | ||
| const { services } = useKibana<{ data: any }>(); | ||
| const { generate: generateBreadcrumbs } = useContext(BreadcrumbContainer.Context); | ||
| const { zoomInfo, onBrush } = useCharts(); | ||
| const clusterUuid = globalState.cluster_uuid; | ||
| const ccs = globalState.ccs; | ||
| const cluster = find(clusters, { | ||
| cluster_uuid: clusterUuid, | ||
| }) as any; | ||
| const [data, setData] = useState({} as any); | ||
| const [beatName, setBeatName] = useState(''); | ||
|
|
||
| const title = i18n.translate('xpack.monitoring.beats.instance.routeTitle', { | ||
| defaultMessage: 'Beats - {instanceName} - Overview', | ||
| values: { | ||
| instanceName: beatName, | ||
| }, | ||
| }); | ||
|
|
||
| const pageTitle = i18n.translate('xpack.monitoring.beats.instance.pageTitle', { | ||
| defaultMessage: 'Beat instance: {beatName}', | ||
| values: { | ||
| beatName, | ||
| }, | ||
| }); | ||
|
|
||
| useEffect(() => { | ||
| if (cluster) { | ||
| generateBreadcrumbs(cluster.cluster_name, { | ||
| inBeats: true, | ||
| instance: beatName, | ||
| }); | ||
| } | ||
| }, [cluster, beatName, generateBreadcrumbs]); | ||
|
|
||
| const getPageData = useCallback(async () => { | ||
| const bounds = services.data?.query.timefilter.timefilter.getBounds(); | ||
| const url = `../api/monitoring/v1/clusters/${clusterUuid}/beats/beat/${instance}`; | ||
| const response = await services.http?.fetch(url, { | ||
| method: 'POST', | ||
| body: JSON.stringify({ | ||
| ccs, | ||
| timeRange: { | ||
| min: bounds.min.toISOString(), | ||
| max: bounds.max.toISOString(), | ||
| }, | ||
| }), | ||
| }); | ||
|
|
||
| setData(response); | ||
| setBeatName(response.summary.name); | ||
| }, [ccs, clusterUuid, instance, services.data?.query.timefilter.timefilter, services.http]); | ||
|
|
||
| return ( | ||
| <BeatsTemplate | ||
| title={title} | ||
| pageTitle={pageTitle} | ||
| getPageData={getPageData} | ||
| instance={instance} | ||
| data-test-subj="beatDetailPage" | ||
| > | ||
| <div data-test-subj="monitoringBeatsInstanceApp"> | ||
| <Beat summary={data.summary} metrics={data.metrics} onBrush={onBrush} zoomInfo={zoomInfo} /> | ||
| </div> | ||
| </BeatsTemplate> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Borrowed the pattern from #113256 here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could even be extracted to its own func as it looks like a good candidate for a unit test :)